getting incorrect {env}{PATH} on win32

[ugexe]

Running strawberry perl 5.20.2 on windows tests fail. The cause appears to be {env}{PATH} having info appended to the end, so it doesn't match. In the following test (1 of 7 failing) we see that a difference of ';.;;.;' vs ';.;;.;;.;'

#   Failed test 'perl t\info.pl'
#   at t/10-command.t line 159.
#     Structures begin differing at:
#          $got->{env}{PATH} = 'C:\Users\Nick\Documents\GitHub\rakudobrew\bin;C:
\Users\Nick\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37
326ad\cmd;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\Sys
tem32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Intel\Services\IPT\;C:\Prog
ram Files (x86)\Skype\Phone\;C:\Program Files (x86)\Windows Kits\8.1\Windows Per
formance Toolkit\;C:\Program Files\Microsoft SQL Server\110\Tools\Binn\;C:\Progr
am Files (x86)\Microsoft SDKs\TypeScript\1.0\;C:\Strawberry\c\bin;C:\Strawberry\
perl\site\bin;C:\Strawberry\perl\bin;.;;.;;.;'
#     $expected->{env}{PATH} = 'C:\Users\Nick\Documents\GitHub\rakudobrew\bin;C:
\Users\Nick\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37
326ad\cmd;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\Sys
tem32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Intel\Services\IPT\;C:\Prog
ram Files (x86)\Skype\Phone\;C:\Program Files (x86)\Windows Kits\8.1\Windows Per
formance Toolkit\;C:\Program Files\Microsoft SQL Server\110\Tools\Binn\;C:\Progr
am Files (x86)\Microsoft SDKs\TypeScript\1.0\;C:\Strawberry\c\bin;C:\Strawberry\
perl\site\bin;C:\Strawberry\perl\bin;.;;.;'

Below is the output of %ENV, which shows that both results above may be considered incorrect, as here the end substring is: ';.;' So we can deduce that at some step of System::Command that ';.;' gets added to {env}{PATH}

# perl -MData::Dumper -e 'print Dumper(%ENV)'
$VAR35 = 'PATH';
$VAR36 = 'C:\\Users\\Nick\\Documents\\GitHub\\rakudobrew\\bin;C:\\Users\\Nick\\A
ppData\\Local\\GitHub\\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\\cmd
;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\Syst
em32\\WindowsPowerShell\\v1.0\\;C:\\Program Files (x86)\\Intel\\Services\\IPT\\;
C:\\Program Files (x86)\\Skype\\Phone\\;C:\\Program Files (x86)\\Windows Kits\\8
.1\\Windows Performance Toolkit\\;C:\\Program Files\\Microsoft SQL Server\\110\\
Tools\\Binn\\;C:\\Program Files (x86)\\Microsoft SDKs\\TypeScript\\1.0\\;C:\\Str
awberry\\c\\bin;C:\\Strawberry\\perl\\site\\bin;C:\\Strawberry\\perl\\bin;.;';

[book]

Nowhere is System::Command touching the PATH environment variable. I'm wondering if the issue is not with the IPC::Run module used by System::Command to work on Windows.

Can you send me the full test report, as it will contain the relevant version information?

Do you get the same results with different versions of Perl or IPC::Run?

[ugexe]

I have not tried it on different Perl/IPC::Run versions. It is worth noting all failed tests involve info.pl, so perhaps its tied to serializing with Data::Dumper?

Test results:
https://gist.github.com/ugexe/c9363af4760cf42d931a

[wchristian]

I tried upgrading IPC::Run to 0.94 and could not reproduce. My Data::Dumper is already at the same version. Recommend you try running the tests standalone and step through them with -d, or more comfortably, with Komodo IDE.

[ugexe]

I had the same results running stand alone as well as when running info.pl
by itself.

On Friday, May 15, 2015, Christian Walde notifications@github.com wrote:

I tried upgrading IPC::Run to 0.94 and could not reproduce. My
Data::Dumper is already at the same version. Recommend you try running the
tests standalone and step through them with -d, or more comfortably, with
Komodo IDE.

—
Reply to this email directly or view it on GitHub
#17 (comment).

[wchristian]

Meaning what? Running the tests standalone also breaks it? If so, GREAT, grab that debugger, whether it be Komodo IDE, commandline -d, https://metacpan.org/pod/Devel::Trepan , https://metacpan.org/pod/Devel::ebug , https://metacpan.org/pod/Devel::ptkdb or anything which lets you pause the execution and see where in the code it is, so you can figure out which bits are munging PATH.

This is necessary to any sort of fixing of this, since neither @book nor i can repro.

[ugexe]

Let me ask you this before I spend any more hours digging into IPC::Run: do you have ;.; in your path when you do perl -e 'print $ENV{PATH}'? If not, there is no reason to go any further as either strawberry perl must be injecting the CWD (as. .) into the PATH for for Perl; The additional ;.; when running the test file would then be the result of strawberry perl tacking on another CWD as it was invoked once by invoking the test itself, and a second time inside the test via IPC::Run.

[wchristian]

No i don't have that in activeperl, or any of my 3 strawberry perls, do you? You've only shown other output so far.

Also what is the output of set for you?

Also, i just noticed you're using linux escaping. Are you in a cygwin shell?

[ugexe]

In the first post you can see the output of my perl -MData::Dumper -e 'print Dumper(%ENV)', which shows the path with ;.; at the end, as well as the output after being run from the System::Command test with ;.;;.;. PATH does not actually contain these values, which is why I think its strawberry perl or windows as of my last reply

Everything is being run from cmd.exe.

Here is my set output:

ALLUSERSPROFILE=C:\ProgramData
APPDATA=C:\Users\Nick\AppData\Roaming
asl.log=Destination=file
CommonProgramFiles=C:\Program Files\Common Files
CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files
CommonProgramW6432=C:\Program Files\Common Files
COMPUTERNAME=T420
ComSpec=C:\Windows\system32\cmd.exe
FP_NO_HOST_CHECK=NO
HOMEDRIVE=C:
HOMEPATH=\Users\Nick
LOCALAPPDATA=C:\Users\Nick\AppData\Local
LOGONSERVER=\\MicrosoftAccount
NUMBER_OF_PROCESSORS=4
OS=Windows_NT
Path=C:\Users\Nick\Documents\GitHub\rakudobrew\bin;C:\Users\Nick\AppData\Local\G
itHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\cmd;C:\Windows\system
32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.
0\;C:\Program Files (x86)\Intel\Services\IPT\;C:\Program Files (x86)\Skype\Phone
\;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit\;C:\Progra
m Files\Microsoft SQL Server\110\Tools\Binn\;C:\Program Files (x86)\Microsoft SD
Ks\TypeScript\1.0\;C:\strawberry\c\bin;C:\strawberry\perl\site\bin;C:\strawberry
\perl\bin
PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
PROCESSOR_ARCHITECTURE=AMD64
PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 42 Stepping 7, GenuineIntel
PROCESSOR_LEVEL=6
PROCESSOR_REVISION=2a07
ProgramData=C:\ProgramData
ProgramFiles=C:\Program Files
ProgramFiles(x86)=C:\Program Files (x86)
ProgramW6432=C:\Program Files
PROMPT=$P$G
PSModulePath=C:\Windows\system32\WindowsPowerShell\v1.0\Modules\
PUBLIC=C:\Users\Public
SESSIONNAME=Console
SystemDrive=C:
SystemRoot=C:\Windows
TEMP=C:\Users\Nick\AppData\Local\Temp
TMP=C:\Users\Nick\AppData\Local\Temp
USERDOMAIN=T420
USERDOMAIN_ROAMINGPROFILE=T420
USERNAME=Nick
USERPROFILE=C:\Users\Nick
VS110COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\Tools
\
VS120COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\Tools
\
windir=C:\Windows

[wchristian]

Thanks, your ENV looks sane.

In the first post you can see the output of my perl -MData::Dumper -e 'print Dumper(%ENV)' , which shows the path with ;.; at the end

You have not explicitly said though whether this also happens without Data::Dumper. Does it?

Further, i have trouble understanding this claim:

Everything is being run from cmd.exe.

Can you please run perl -e 'print $ENV{PATH}' in your shell and copy/paste the entire window contents?

And then try and run this for comparison to see if it's any different: perl -e "print $ENV{PATH}"

[ugexe]

Ah I see the confusion now. The single quotes are out of habit, and I just typed the command in as a comment instead of pasting the entire path + ENV info. Single quotes do not work. However I did use double quotes to generate all output thus far.

C:\Users\Nick>perl -e "print $ENV{PATH}"
C:\Users\Nick\Documents\GitHub\rakudobrew\bin;C:\Users\Nick\AppData\Local\GitHub
\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\cmd;C:\Windows\system32;C:
\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:
\Program Files (x86)\Intel\Services\IPT\;C:\Program Files (x86)\Skype\Phone\;C:\
Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit\;C:\Program Fil
es\Microsoft SQL Server\110\Tools\Binn\;C:\Program Files (x86)\Microsoft SDKs\Ty
peScript\1.0\;C:\strawberry\c\bin;C:\strawberry\perl\site\bin;C:\strawberry\perl
\bin;.;

[wchristian]

Try this:

perl -e "print( qq[$_ => $INC{$_}\n] ) for keys %INC"

And if anything pops up in there, have a look and see what it's doing.

Also, what exactly is the perl you're using, can you link the installer you used, and paste a perl -V?