View posts by user should (optionally) include resteems.

[toniwidmo]

At the moment a users posts, as viewed on either the post listing page, or their profile page, excludes resteems. It would be good if it could optionally include them.

[toniwidmo]

https://jsfiddle.net/bonustrack/24b7ky2s/2/

^ This should help.

[toniwidmo]

Basically, in module/steem.js we currently use steem.api.getDiscussionsByAuthorBeforeDate to get the users steem posts. Instead we should use steem.api.getDiscussionsByBlog if we want to get resteems.

Do we want lists without resteems? If so, do we just hide them using css/javascript? Or do we need both get methods triggered by a config switch?

In option 1 we are saying decision to hide resteems is a theme/styling decision.
In option 2 we are saying code should know what we doing an handle appropriately.

In option 1, changing theme will change behaviour of listing.
In option 2, changing theme will not change behaviour. Only changing config will.

[danawidmo]

In my opinion option, 2 is better. It seems more logical that this change/decision should be determined in the config file and not in the theme.

[toniwidmo]

I agree. If a site admin wants one or the other behaviour, they won't want changing a theme to mess it up. Option 2 gives them more flexibility.