[Bug] Dune Destination Save Doesn't Fail on Raised Error

[bh2smith]

While working the test adjustments to #129 - I noticed that we are only catching and logging errors. Not actually failing. Furthermore, we return the number of data points as if that were the number of affected rows. This can lead to incomplete jobs passing silently.

Some ideas:

• Allow the errors to be raised
• return boolean from job.run based on success or raised error
• collect failures at the end
• Report on failed jobs.

I am currently working on this task directly involving DuneDestination.save. Not sure if this should be fixed independently or just repaired in the overhaul.

[fhenneke]

We ran into that bug in one of our deployments, cc @bram-vdberg @alex-zadorozhnyi.

Would you accept a PR on this, @bh2smith , or do you want to tackle this yourself?

[bh2smith]

Would you accept a PR on this

Absolutely, if you have something ready. It will still be a while before #129 sees the light of day.