From 5de21818ae191be924c2e93f3096ca7b1299d6c5 Mon Sep 17 00:00:00 2001 From: Joan Miquel Date: Thu, 15 May 2025 21:52:46 +0200 Subject: [PATCH 1/3] Simplify PHP code for fibonacci --- fibonacci/php/code.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fibonacci/php/code.php b/fibonacci/php/code.php index c72c67ef..5ca2103f 100644 --- a/fibonacci/php/code.php +++ b/fibonacci/php/code.php @@ -2,9 +2,10 @@ function fibonacci(int $n): int { - if ($n == 0) return 0; - if ($n == 1) return 1; - return fibonacci($n - 1) + fibonacci($n - 2); + return match($n) { + 0,1 => $n, + default fibonacci($n - 1) + fibonacci($n - 2) + } } $u = (int) $argv[1]; From 8b85e80141f9bb4f0d5c11d06669ffc11b461d2d Mon Sep 17 00:00:00 2001 From: Joan Miquel Date: Thu, 15 May 2025 22:06:27 +0200 Subject: [PATCH 2/3] Fix code --- fibonacci/php/code.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fibonacci/php/code.php b/fibonacci/php/code.php index 5ca2103f..4719478f 100644 --- a/fibonacci/php/code.php +++ b/fibonacci/php/code.php @@ -4,8 +4,8 @@ function fibonacci(int $n): int { return match($n) { 0,1 => $n, - default fibonacci($n - 1) + fibonacci($n - 2) - } + default => fibonacci($n - 1) + fibonacci($n - 2) + }; } $u = (int) $argv[1]; From 3a700e6411014c575a5eef5ed349ff2d1e323aed Mon Sep 17 00:00:00 2001 From: Joan Miquel Date: Sun, 18 May 2025 14:08:38 +0200 Subject: [PATCH 3/3] PHP use only 1 comparision --- fibonacci/php/code.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fibonacci/php/code.php b/fibonacci/php/code.php index 4719478f..f5fe61b3 100644 --- a/fibonacci/php/code.php +++ b/fibonacci/php/code.php @@ -2,10 +2,8 @@ function fibonacci(int $n): int { - return match($n) { - 0,1 => $n, - default => fibonacci($n - 1) + fibonacci($n - 2) - }; + if ($n < 2) return $n; + return fibonacci($n - 1) + fibonacci($n - 2); } $u = (int) $argv[1];