Skip to content

Use more props to make the SkeletonTable match the actual table visually #80

@bastilian

Description

@bastilian

Currently we use the SkeletonTable very barebones, by only setting the rows and columns, but there are more props[0] that could be set to make the SkeletonTable match the visual appearance of the actual table.

For this we should

  • Set is isExpandable if the table has a details component
  • Set isSelectable if bulk select is enabled
  • Set the appropriate variant (compact or not)
  • Set the right selectVariant (radio/checkbox)

In the course of this change we could also look into exposing enabled features via the context to make them easily accessible anywhere in the table.

[0] https://www.patternfly.org/component-groups/status-and-state-indicators/skeleton-table/#props

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions