-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
- Design is easy on the eyes, and overall readability feels strong. I’m still a little unsure about how the green ties into the rest of the palette. Maybe try experimenting with a darker green for contrast (especially in the title areas) so the text stands out more against the softer background
- The font choice works well! Everything is very readable
- Adding onto that, you could try slightly increasing the font size and line-height. Just keep an eye on the rag on the right so the text still feels balanced
- For your CSS, you might want to import your stylesheets instead of linking them directly, as shown in our Week 12 tutorial. You already have it set up correctly on the homepage, so it would just be about making the rest consistent (e.g., using @import 'reset.css' layer(reset); instead of )
- Cleaning up spacing and indentation throughout your code would make everything feel more organised and easier to maintain
- You might reconsider some of the div usage for elements like id="line"or id="top-line". There might be a more semantic element you can use, or you could toggle visibility with another approach. Not a requirement, just something to consider and think about for best practice. I could be wrong though...
- The whitespace in the nav and footer feels a bit heavy compared to the text size. Adjusting the padding or margin slightly could help even out the proportions
- Not seeing a clear indicator for which page I’m currently on. Adding something in the header or nav (like an active state) might help users understand where they are without relying on the URL or title alone
- When I test Articles 01 and 02 around 400px with the viewport in Chrome, the author and date get cut off. A small responsive adjustment should fix that, and even bumping down the H1 font-size at that breakpoint might help everything fit more comfortably. Something you’ve shown me in the past!
- I noticed all your paragraph tags are being targeted using class="pg". If you’re using the paragraph tag consistently, it might be worth seeing if you can simplify by styling the tag itself and only adding classes when needed. That might help tidy things up
mfehrenbach
Metadata
Metadata
Assignees
Labels
No labels