From 9da4a8f2eeba1d962e7e074583c5300a030b3fee Mon Sep 17 00:00:00 2001 From: argiepiano Date: Fri, 5 Apr 2024 18:52:04 -0600 Subject: [PATCH 1/2] Issue #173. Move the "comment" node property info to comment.info.inc --- modules/comment.info.inc | 7 ++++--- modules/node.info.inc | 9 --------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/modules/comment.info.inc b/modules/comment.info.inc index ed2e4bc..0f4d813 100644 --- a/modules/comment.info.inc +++ b/modules/comment.info.inc @@ -131,11 +131,12 @@ function entity_plus_metadata_comment_entity_property_info_alter(&$info) { // Add info about comment module related properties to the node entity. $properties = &$info['node']['properties']; $properties['comment'] = array( - 'label' => t("Comments allowed"), - 'description' => t("Whether comments are allowed on this node: 0 = no, 1 = closed (read only), 2 = open (read/write)."), + 'label' => t("Comments settings"), + 'description' => t("Whether comments are allowed on this node."), 'setter callback' => 'entity_plus_property_verbatim_set', - 'setter permission' => 'administer comments', + 'setter permission' => 'administer comment settings', 'type' => 'integer', + 'options list' => 'entity_plus_metadata_node_comment_settings_options_list', ); $properties['comments'] = array( 'label' => t("Comments"), diff --git a/modules/node.info.inc b/modules/node.info.inc index 2e7201f..2ef3b10 100644 --- a/modules/node.info.inc +++ b/modules/node.info.inc @@ -152,15 +152,6 @@ function entity_plus_metadata_node_entity_property_info() { 'setter callback' => 'entity_plus_property_verbatim_set', 'access callback' => 'entity_plus_metadata_node_revision_access', ); - $properties['comment'] = array( - 'label' => t('Comment settings'), - 'description' => t("Whether the comments are allowed on this node."), - 'type' => 'integer', - 'setter callback' => 'entity_plus_property_verbatim_set', - 'setter permission' => 'administer comment settings', - 'schema field' => 'comment', - 'options list' => 'entity_plus_metadata_node_comment_settings_options_list', - ); return $info; } From 058ea703d352014ad82842a66fd809a677887b1b Mon Sep 17 00:00:00 2001 From: argiepiano Date: Sun, 27 Jul 2025 15:03:01 -0600 Subject: [PATCH 2/2] Issue #183. More updates for functional tests. Fixes #183 --- .github/workflows/functional-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/functional-tests.yml b/.github/workflows/functional-tests.yml index a719879..d5051f3 100644 --- a/.github/workflows/functional-tests.yml +++ b/.github/workflows/functional-tests.yml @@ -13,7 +13,7 @@ jobs: - name: Install MariaDB uses: shogo82148/actions-setup-mysql@v1 with: - mysql-version: 'mariadb-10.5' + mysql-version: 'mariadb-10.11' root-password: 'root' auto-start: true @@ -30,12 +30,12 @@ jobs: coverage: none - name: Checkout Backdrop core - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: repository: backdrop/backdrop - name: Checkout module - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: path: modules/${{ env.REPO_NAME }}