Skip to content

Logic app accesscontrol validations #1365

@psyduck101

Description

@psyduck101

Hey,
We are building arm templates for our logic apps and APIM apis( only apis, not the apim instance) and we get some positives that we wonder if they are correct and we are missing something or we can just disable them.

Version 4.14 in powershell

  1. We have logic apps where we added accesscontrol ipranges ( hardcoded and by parameter). And we keep getting the warnings of methods CheckTriggersAccessControl/CheckContentsAccessControl that they are not present or missing.

    Azure_LogicApps_AuthZ_Provide_Triggers_Access_Control | Failed | High | Not found |   | $.properties.accessControl.triggers.allowedCallerIpAddresses.addressRange | Verify current value | resources[0] | 70 | If Logic App fires on an HTTP Request (e.g.   Request or Webhook) then provide IP ranges for triggers ...
    
    Azure_LogicApps_AuthZ_Provide_Contents_Access_Control | Failed | High | Not found |   | $.properties.accessControl.contents.allowedCallerIpAddresses.addressRange | Verify current value | resources[0] | 70 | Must provide IP ranges for contents to prevent unauthorized access to..._
    
  2. We deploy our apim apis, seperately from the apim instance. But for the apis, we get the remark that our api is not linked to a vnet. As far as i know, vnet is only configured on the apim instance.

       _Azure_APIManagement_NetSec_Configure_Virtual_Network_For_APIM | **Microsoft.ApiManagement/service ,  Microsoft.ApiManagement/service/apis** | Medium | Not found | -1 |   | $.properties.virtualNetworkType | NotAllow 'None' |resources[6] | 159 | Consider hosting APIM within a virtual   network for improved isolation_
    

Part of my logic app (also tried with parameters instead of hardcoded, or used cidr syntax '10.0.0.0/24')

  "type": "Microsoft.Logic/workflows",
      "apiVersion": "2017-07-01",
      "name": "[parameters('logicapp-testcon-name')]",
      "location": "[parameters('logicapp-location')]",
      "tags": "[parameters('resourceTags')]",
      "properties": {
        "state": "Enabled",
        "accessControl": {
          "triggers": {
            "allowedCallerIpAddresses": [
              {
                "addressRange": "10.0.0.0-11.0.0.0"
              }
            ]
          },
          "contents": {
            "allowedCallerIpAddresses": [
              {
                "addressRange": "10.0.0.0-11.0.0.0"
              }
            ]
          }
        },

To reproduce

Execute on a logic app arm template with accesscontrol configured.

Expected behavior

Not to have the errors

Actual behavior

Getting validation errors

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions