From 89089a7b5f4a28bf3f358804f2bd31da473e8ba8 Mon Sep 17 00:00:00 2001 From: musunita <62577111+musunita@users.noreply.github.com> Date: Tue, 6 Feb 2024 13:09:46 -0800 Subject: [PATCH 1/3] Update pull_request_template.md fix errors --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ba4bccb0..f341b04e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -33,7 +33,7 @@ https://awsdocs-neuron-staging.readthedocs-hosted.com/en/YOUR_BRANCH_NAME/ - [ ] (If applicable) I've automated a test to safegaurd my changes from regression. - [ ] (If applicable) I've posted test collateral to prove my change was effective and not harmful. - [ ] (If applicable) I've added someone from QA to the list of reviewers. Do this if you didn't make an automated test or feel it's appropriate for another reason. -- [ ] (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the pre-approved Amazon license list. See https://inside.amazon.com/en/services/legal/us/OpenSource/Pages/BlessedOpenSourceLicenses.aspx. + ## Pytest Marker Checklist From 7a420a64700c018d341e2d64c3e2afc09dcf4824 Mon Sep 17 00:00:00 2001 From: musunita <62577111+musunita@users.noreply.github.com> Date: Tue, 6 Feb 2024 13:13:07 -0800 Subject: [PATCH 2/3] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f341b04e..5c443398 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,7 +19,7 @@ If possible, provide your results or a link to them for the reviewer to check yo *Link to RTD for my changes:* -https://awsdocs-neuron-staging.readthedocs-hosted.com/en/YOUR_BRANCH_NAME/ +https://awsdocs-neuron.readthedocs-hosted.com/en/YOUR_BRANCH_NAME/ *Additional context:* From 2f440aac0f43e5b03e462b2c25549c25ba17ed63 Mon Sep 17 00:00:00 2001 From: musunita <62577111+musunita@users.noreply.github.com> Date: Tue, 6 Feb 2024 13:14:25 -0800 Subject: [PATCH 3/3] Update pull_request_template.md --- .github/pull_request_template.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5c443398..c3df24d5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,8 +6,9 @@ Please specify the release version, instance size and type, OS type and test output. Training tutorial: -Convergence graph for training tutorials -Performance metrics average_throughput, latency_p50, latency_p99 and MFU% if available +Please attach convergence graph for training tutorials. + +Please attache performance metrics average_throughput, latency_p50, latency_p99 and MFU% if available Please make sure this PR contains correct classification terms (Alpha, Beta, and Stable).