Conversation
- enabled submodule usage - changed xxd invocation (old xxd instances do not support -n, the output seems to be the same though) - changed relative symlinks - those break when cloning the repo somewhere not on Github - one addition for pcap/slirp was needed for MacOS compilation in the libretro env
audetto
reviewed
Feb 11, 2026
source/CMakeLists.txt
Outdated
| target_link_libraries(appleii PUBLIC | ||
| yaml | ||
| minizip | ||
| ${PCAP_LIBRARIES} |
Owner
There was a problem hiding this comment.
This can't be here. A lot effort went into allowing the static build to work.
This is anyway a static library, so it should not require these symbols, which are already added to each target project.
I'd rather put here all the static or dynamic libraries needed, but I had an argument with cmake and I lost it.
What is the exact problem?
Author
There was a problem hiding this comment.
When the extra libpcap detection was needed, it did not propagate to source/frontends/libretro. I have changed the approach, is it more acceptable this way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some changes that enabled finally to get all currently configured 7 builds compiling (linux 32/64, windows 32/64, android, ios, macos) https://git.libretro.com/warmenhoven/applewin/-/pipelines/46992
.gitlab-ci.yml-- this one shouldn't disturb anyoneI hope also other changes can be taken: