Incorrect Task Result for 'Deploy_node'

[eanylin]

The Drydock_Build workflow will be executed when we run the update_site workflow via Shipyard. The flow will go through without issue until the deploy_node step when Drydock will skip the deployment step for nodes that are already deployed. While this is the correct behavior from Drydock, it is returning incorrect task_result, i.e. failure instead of success.

Drydock Logs:

2018-03-06 18:57:51,974 - WARNING - orchestrator.py:start - No nodes successfully networked, skipping storage configuration subtask.
2018-03-06 18:57:51,974 - WARNING - orchestrator.py:start - No nodes with storage configuration, skipping platform configuration subtask.
2018-03-06 18:57:51,974 - WARNING - orchestrator.py:start - Unable to configure platform on any nodes, skipping deploy subtask
2018-03-06 18:57:51,974 - DEBUG - task.py:bubble_results - Bubbling subtask results up to task 253e456d-edfd-47fb-ab34-164ab91237ce.
2018-03-06 18:57:51,982 - DEBUG - task.py:bubble_results - Skipping subtask due to action filter.
2018-03-06 18:57:51,995 - DEBUG - task.py:align_result - Collecting result status from subtask 74b30482-8361-476c-a59a-080c9a8e146a.
2018-03-06 18:57:51,999 - DEBUG - state.py:get_task - Assembling result messages for task 253e456d-edfd-47fb-ab34-164ab91237ce.
2018-03-06 18:57:53,541 - DEBUG - orchestrator.py:watch_for_tasks - Task execution complete, looking for the next task.

Airflow Logs:

[2018-03-06 18:56:49,244] {{base_task_runner.py:98}} INFO - Subtask: [2018-03-06 18:56:49,244] {{drydock_operators.py:307}} INFO - Drydock deploy_nodes task ID is 253e456d-edfd-47fb-ab34-164ab91237ce
[2018-03-06 18:56:49,245] {{base_task_runner.py:98}} INFO - Subtask: [2018-03-06 18:56:49,244] {{drydock_operators.py:283}} INFO - Task ID is 253e456d-edfd-47fb-ab34-164ab91237ce
[2018-03-06 18:56:49,287] {{base_task_runner.py:98}} INFO - Subtask: [2018-03-06 18:56:49,286] {{drydock_operators.py:344}} INFO - Current status of task id 253e456d-edfd-47fb-ab34-164ab91237ce is queued
[2018-03-06 18:57:19,324] {{base_task_runner.py:98}} INFO - Subtask: [2018-03-06 18:57:19,323] {{drydock_operators.py:344}} INFO - Current status of task id 253e456d-edfd-47fb-ab34-164ab91237ce is running
[2018-03-06 18:57:49,379] {{base_task_runner.py:98}} INFO - Subtask: [2018-03-06 18:57:49,379] {{drydock_operators.py:344}} INFO - Current status of task id 253e456d-edfd-47fb-ab34-164ab91237ce is running
[2018-03-06 18:58:19,426] {{base_task_runner.py:98}} INFO - Subtask: [2018-03-06 18:58:19,425] {{drydock_operators.py:344}} INFO - Current status of task id 253e456d-edfd-47fb-ab34-164ab91237ce is complete
[2018-03-06 18:58:19,426] {{base_task_runner.py:98}} INFO - Subtask: [2018-03-06 18:58:19,426] {{drydock_operators.py:386}} INFO - Task result is failure