Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

bug: first-mate 7.x does not work in Travis with Node 6 #60

@bcoe

Description

@bcoe

@as-cii we're running into a nasty issue with marky-markdown on Travis (marky-markdown is what npm uses to render package READMEs on npmjs.com).

We're trying to upgrade to the newest highlights, so that we can pull in syntax highlighting for Typescript and JSX, but when I upgrade to the newest highlights tests start hanging infinitely and timing out on Travis.

I've managed to bisect this issue to the 6.x to 7.x first-mate upgrade in highlights -- tests run fine in Node 8, and they run fine locally with Node 6, but I'm concerned that Travis might be surfacing an underlying instability that we should be mindful of.

Looping in @revin who's been helping out a ton on the marky-markdown project.


Any thoughts about next steps? If I had to guess, I'd bet the issue is either the oniguruma or fs-plus upgrade in first-mate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions