diff --git a/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java b/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java index 46e9fe134686..28b04f889b8f 100644 --- a/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java +++ b/maven-core/src/main/java/org/apache/maven/plugin/MavenPluginPrerequisitesChecker.java @@ -31,7 +31,7 @@ public interface MavenPluginPrerequisitesChecker extends Consumer { /** * - * @param pluginDescriptor + * @param pluginDescriptor the plugin descriptor to check * @throws IllegalStateException in case the checked prerequisites are not met */ @Override diff --git a/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java b/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java index d3c5edbf95bb..1e2c26168bf4 100644 --- a/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java +++ b/maven-core/src/main/java/org/apache/maven/plugin/PluginIncompatibleException.java @@ -26,10 +26,6 @@ public class PluginIncompatibleException extends PluginManagerException { public PluginIncompatibleException(Plugin plugin, String message) { - this(plugin, message, null); - } - - public PluginIncompatibleException(Plugin plugin, String message, Throwable cause) { - super(plugin, message, cause); + super(plugin, message, (Throwable) null); } } diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java index 85ae59530db3..5e80e0c6525a 100644 --- a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java +++ b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java @@ -296,15 +296,15 @@ public void checkPrerequisites(PluginDescriptor pluginDescriptor) throws PluginI }); // aggregate all exceptions if (!prerequisiteExceptions.isEmpty()) { + String ln = System.lineSeparator(); String messages = prerequisiteExceptions.stream() .map(IllegalStateException::getMessage) - .collect(Collectors.joining(", ")); + .collect(Collectors.joining(ln + '\t')); PluginIncompatibleException pie = new PluginIncompatibleException( pluginDescriptor.getPlugin(), - "The plugin " + pluginDescriptor.getId() + " has unmet prerequisites: " + messages, - prerequisiteExceptions.get(0)); - // the first exception is added as cause, all other ones as suppressed exceptions - prerequisiteExceptions.stream().skip(1).forEach(pie::addSuppressed); + ln + "The plugin " + pluginDescriptor.getId() + " has unmet prerequisites: " + ln + '\t' + + messages); + prerequisiteExceptions.forEach(pie::addSuppressed); throw pie; } }