[MNG-7771] Don't use ArtifactResolutionException#getMessage() w/o knowing whether there are other exceptions or not

[jira-importer]

Michael Osipov opened MNG-7771 and commented

ArtifactResolutionException#getMessage() only considers the message from the first cause, completely ignoring other causes. So it is order-dependent and can be misleading. Create an expeception-agnotic message and all submessages shall be retrieved through API.

---

Affects: 3.8.8, 3.9.1, 4.0.0-alpha-5

This issue is a sub-task of MNG-7770

Backported to: 4.0.x-candidate, 3.9.x-candidate

[jira-importer]

Guillaume Nodet commented

AFAIK, ArtifactResolutionException are thrown from old services in maven-compat, so I don't think we should waste any time on those.

[jira-importer]

Michael Osipov commented

No, they come straight from Resolver otherwise I would not raise. This is a seriously annoying issue.

[jira-importer]

Michael Osipov commented

Tamas Cservenak 

[jira-importer]

Tamas Cservenak commented

There are several of these:

https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionException.java

But we talk about resolver one:

https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResolutionException.java

Yes, Resolver 2.0.0 makes possible now to create more meaningful (and precise) messages, as this new method is added:

https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResult.java#L141

[jira-importer]

Guillaume Nodet commented

I don't see any place in Maven where this exception is created.  AFAIK, it always comes from the resolver.

[jira-importer]

Michael Osipov commented

gnodet, it is not, but it is visible through Maven to the user.

[jira-importer]

Guillaume Nodet commented

Michael Osipov That was my understanding too.  But then, shouldn't we move the issue to maven-resolver ?

I don't really understand what you expect from Maven.

[jira-importer]

Tamas Cservenak commented

The exception carries multiple important information, and this really about formatting understandable, meaningful, but at the same time complete error message on console (to user) in case it is being thrown.

[jira-importer]

Tamas Cservenak commented

So this is more about "consuming" and formatting console output for user when this exception is thrown.

[jira-importer]

Michael Osipov commented

Correct, Tamas Cservenak nailed it mostly. The information has to be in the exception and Maven has to expose it correct. Neither is. Even if the issue is not in Maven per sé, the issue is visible from Maven from a user's PoV.