[MGPG-129] sign-and-deploy-file incorrectly renames source files when deployed.

[jira-importer]

Lee Rhodes opened MGPG-129 and commented

You can see from the Debug_output.txt (line 209) that the source files are of the form: "datasketches-memory-3.0.0.jar", "datasketches-memory-3.0.0-tests.jar", etc.

But the files being deployed (line 252) are of the form: "datasketches-memory-root-3.0.0.jar", etc. This extra "-root" is incorrect.

How do I fix this so that the given files are just signed and deployed without being renamed?

This can be replicated from the open-source site: https://github.com/apache/datasketches-memory/tree/3.0.X.
First run the "package-multi-release-jar.sh", which creates the source files under /target/. Then run the script "sign-deploy-jar.sh" with inputs "3.0.0" <local project directory>. You will need an account on Nexus.

BTW, the source file names have to be different from the root project name because the source files are MR-Jars that have been assembled by the above "package-multi-release-jar.sh".

"sign-and-deploy-file" does not just sign and deploy the given source files, it is also renaming them, which causes the deployed files to have incorrect names.

---

Affects: 3.0.1, 3.2.3, 3.2.4

Attachments:

• Debug_output.txt (30.29 kB)
• package-multi-release-jar.sh (8.72 kB)
• pom.xml (18.92 kB)
• sign-deploy-jar.sh (2.84 kB)

[jira-importer]

Tamas Cservenak commented

This is not GPG plugin issue but more like Maven and/or invocation.
The source checkout https://github.com/apache/datasketches-memory/tree/3.0.X root POM has artifactId datasketches-memory-root so it seems is being picked up?
Can you reproduce when you invoke sign-and-deploy outside of git checkout (from dir where there is no POM)?
Which Maven version you use?

[jira-importer]

Tamas Cservenak commented

Assumed solution: your sign-and-deploy.sh does NOT specify groupId and artifactId, hence it relies on values coming from POM. Hence, if you invoke this script from git checkout root (where POM has artifactId=datasketches-memory-root... ) it will pick up artifactId value from POM. Hence, modify your script (add -DartifactId=...) or alike explicitly. This is standard Maven behaviour.