Color names not translated

[RrBd1957]

KANBOARD Version: 1.2.48
PHP Version: 8.3.25-nmm1
PHP SAPI: fpm-fcgi
HTTP-Client: cURL
OS Version: Linux 6.8.0-64-generic
Datenbanktreiber: mysql
Datenbank Version: 10.11.13-MariaDB-0ubuntu0.24.04.1-log
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:146.0) Gecko/20100101 Firefox/146.0
Language: de_DE

Lots of Plugins

So Color Manager looks for me in FF:

[alfredbuehler]

Here is the patch:

diff --git a/Template/config/colors.php b/Template/config/colors.php
index a93e547..74477b9 100644
--- a/Template/config/colors.php
+++ b/Template/config/colors.php
@@ -41,7 +41,7 @@ $customColours = is_null(count($this->task->colorModelExt->getCustomColors())) ?
         <?php asort($defaultColours) ?>
         <?php foreach ($defaultColours as $color_id => $color): ?>
             <div class="colour-wrapper" style="background-color: <?= $color['background'] ?>; border-color: <?= $color['border'] ?>;" title="<?= $color['name'] ?>">
-                <div class="colour-name"><?= $color['name'] ?></div>
+                <div class="colour-name"><?= t($color['name']) ?></div>
                 <div class="colour-background">
                     <span class=""><?= t('Background Color') ?></span>
                     <code class="">
@@ -86,7 +86,7 @@ $customColours = is_null(count($this->task->colorModelExt->getCustomColors())) ?
             <?php // phpcs:disable Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace,Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore -- code must be kept intact?>
             <div class="colour-wrapper" style="<?php if (isset($color['font'])): ?>color: <?= $color['font'] ?>;<?php endif ?> background-color: <?= $color['background'] ?>; border-color: <?= $color['border'] ?>;" title="<?= t($color['name']) ?>">
                 <?php // phpcs:enable ?>
-                <div class="colour-name"><?= $color['name'] ?></div>
+                <div class="colour-name"><?= t($color['name']) ?></div>
                 <div class="colour-background">
                     <span class=""><?= t('Background Color') ?></span>
                     <code class="">
@@ -131,7 +131,7 @@ $customColours = is_null(count($this->task->colorModelExt->getCustomColors())) ?
             <?php // phpcs:disable Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace,Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore -- code must be kept intact?>
             <div class="colour-wrapper" style="<?php if (isset($color['font'])): ?>color: <?= $color['font'] ?>;<?php endif ?> background-color: <?= $color['background'] ?>; border-color: <?= $color['border'] ?>;" title="<?= t($color['name']) ?>">
                 <?php // phpcs:enable ?>
-                <div class="colour-name"><?= $color['name'] ?></div>
+                <div class="colour-name"><?= t($color['name']) ?></div>
                 <div class="colour-background">
                     <span class=""><?= t('Background Color') ?></span>
                     <code class="">
@@ -197,7 +197,7 @@ $customColours = is_null(count($this->task->colorModelExt->getCustomColors())) ?
             <i class="fa fa-info-circle"></i> <?= t('Color names matching colors in other palettes will override those colors. Duplicate color names will not be created.') ?>
         </p>
     </div>
-    
+
 
     <div class="colour-boxes">
         <?php asort($customColors) ?>

Entire file in case of problems : https://termbin.com/zv3f

[RrBd1957]

alfredbuehler's fix works fine

One remaining Problem:

I can't find out how to translate the "Yellow" (top left in my screenshot). "Yellow" is added in my revised Locale (Download folder for your Tests here (7 days available)=.
Thought reason might be that "Yellow" is missing in "ColorModelExt.php", but adding did not resolve the problem.
Your Ideas?

[alfredbuehler]

I can't find out how to translate the "Yellow" (top left in my screenshot).

diff --git a/Template/config/colors.php b/Template/config/colors.php
index a93e547..d4afa1b 100644
--- a/Template/config/colors.php
+++ b/Template/config/colors.php
@@ -28,7 +28,7 @@ $customColours = is_null(count($this->task->colorModelExt->getCustomColors())) ?
             <li class="">
                 <strong><?= t('Task Color') ?>:</strong>
                 <span class="default-box-colour" style="background-color: <?= $defaultBackground ?>; border-color: <?= $defaultBorder ?>;">
-                    <?= ucfirst($this->task->colorModel->getDefaultColor()); ?>
+                    <?= t(ucfirst($this->task->colorModel->getDefaultColor())); ?>
                 </span>
             </li>
             <li class="color-manager-note">

[RainerBielefeld]

Yes, works for "Yellow" and others. But also see #44