[bug]: version 3.3.2 does not support PHP 7.2?

[dosinabox]

Description

Version 3.3.2 claims to support PHP 7.2:

"require": {
    "php": "^7.2 || ^8.0",

However, it uses constants and features that are only available starting from PHP 7.3:

$parameters[$key] = json_encode($value, JSON_THROW_ON_ERROR);

As a result, this triggers two warnings on every search request when running on PHP 7.2.34.

Client

Search

Version

3.3.2

Relevant log output

Warning: Use of undefined constant JSON_THROW_ON_ERROR - assumed 'JSON_THROW_ON_ERROR' (this will throw an Error in a future version of PHP) in /xxx/vendor/algolia/algoliasearch-client-php/src/Support/Helpers.php on line 138
Warning: json_encode() expects parameter 2 to be integer, string given in /xxx/vendor/algolia/algoliasearch-client-php/src/Support/Helpers.php on line 138

[eric-zaharia]

Hey @dosinabox, thank you for flagging this issue! Unfortunately version 3.3.2 does not support PHP 7.2, we updated the requirements starting with version 3.4.0.

[dosinabox]

So what is the latest version that actually supports PHP 7.2?
Based on my research, it appears to be 2.7.2. Can you confirm this?

JSON_THROW_ON_ERROR was added in this commit: 0097572

Warnings aside, are there any other known incompatibilities with PHP 7.2 in version 3.3.2?

[eric-zaharia]

You're correct that version 2.7.2 (and 2.7.3) is the last version that supports PHP 7.2. However, these versions were released over 5 years ago and are unfortunately no longer supported.