-
Notifications
You must be signed in to change notification settings - Fork 47
Description
Hey @adamrehn ,
When invoking Editor build process, the following logic will always run inside of buildDescriptor() call:
ue4cli/ue4cli/UnrealManagerBase.py
Lines 369 to 372 in fed71c1
| # If we're using a source build of the Engine then make sure ShaderCompileWorker is built before building project Editor modules | |
| if noTools == False and self.isInstalledBuild() == False and self.isProject(descriptor) and target == 'Editor': | |
| Utility.printStderr('Ensuring ShaderCompileWorker is built before building project Editor modules...') | |
| self.buildTarget('ShaderCompileWorker', 'Development', [], suppressOutput) |
As I understand, this was requested by #14 and added with 259d03c However, I have a feeling the change should be reverted. Said logic wastes few seconds for invoking additional build. ue4 build isn't meant to bootstap the Engine and building the ShaderCompilerWorker wouldn't solve said issue anyway as Unreal needs more modules to function properly such as CrashReportClient, UnrealFrontend, UnrealLightmass, etc
User is expected to bootstrap Unreal before using ue4 build. If we want to suport bootstraping from ue4cli we should probably make a custom command.
Also, looking through #14 it seems that this case was a problem with OP's environment setup as he was using a custom Engine source. This wasn't a bug with ue4cli and I doubt anyone else would encounter it. Though I might be mistaken.
Cheers!