Partial download does not result in non-zero error code

[lilyball]

If carthage_cache fails to download the full archive, it still tries to unzip it, and it ignores any errors reported by the unzip. The output of the tool includes

  error:  invalid compressed data to inflate
file #766:  bad zipfile offset (lseek):  137224192
file #767:  bad zipfile offset (local header sig):  137230240
file #768:  bad zipfile offset (local header sig):  137230299
file #769:  bad zipfile offset (local header sig):  137230622
file #770:  bad zipfile offset (local header sig):  137231506
…

so I can see it in the log, but carthage_cache itself must still be exiting with code 0 because my Makefile continues building the project.

This is with version 0.4.0, but I don't see anything relevant in the subsequent commit log.

[guidomb]

You are correct. carthage_cache is not checking if the archive was successfully downloaded. That check should be done here and the repository should report the error, check here.

Feel like sending a PR to fix this?

[lilyball]

I literally haven't touched Ruby in over 8 years, so I'd rather let someone who's a little less rusty submit the PR.