From 42379177af8790a6a3c20e424843c84c02bcd7ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sat, 21 Dec 2024 22:48:18 +0100
Subject: [PATCH 01/10] xdg-activation: add focus stealing prevention when
 using tokens

---
 metadata/xdg-activation.xml          |  5 +++
 plugins/protocols/xdg-activation.cpp | 66 ++++++++++++++++++++++++++++
 2 files changed, 71 insertions(+)

diff --git a/metadata/xdg-activation.xml b/metadata/xdg-activation.xml
index 6eb8c5514..71fe62a12 100644
--- a/metadata/xdg-activation.xml
+++ b/metadata/xdg-activation.xml
@@ -14,6 +14,11 @@
 			<_long>Whether to reject activation requests if a newer request has arrived since their creation.</_long>
 			<default>false</default>
 		</option>
+		<option name="focus_stealing_prevention" type="bool">
+			<_short>Prevent stealing focus by an activation request</_short>
+			<_long>Whether to reject an activation request if the user interacted with a different view since its creation.</_long>
+			<default>true</default>
+		</option>
 		<option name="timeout" type="int">
 			<_short>Timeout for activation (in seconds)</_short>
 			<_long>Focus requests will be ignored if at least this amount of time has elapsed between creating and using it.</_long>
diff --git a/plugins/protocols/xdg-activation.cpp b/plugins/protocols/xdg-activation.cpp
index d87beee53..5926b19af 100644
--- a/plugins/protocols/xdg-activation.cpp
+++ b/plugins/protocols/xdg-activation.cpp
@@ -36,6 +36,12 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         xdg_activation_new_token.disconnect();
         xdg_activation_token_destroy.disconnect();
         last_token = nullptr;
+        if (last_view)
+        {
+            last_view->disconnect(&on_view_unmapped);
+            last_view->disconnect(&on_view_deactivated);
+            last_view = nullptr;
+        }
     }
 
     bool is_unloadable() override
@@ -64,6 +70,17 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
 
             last_token = nullptr; // avoid reusing the same token
 
+            if (last_view)
+            {
+                last_view->disconnect(&on_view_unmapped);
+                last_view->disconnect(&on_view_deactivated);
+                last_view = nullptr;
+            } else if (prevent_focus_stealing)
+            {
+                LOGI("Denying focus request, requesting view has been deactivated");
+                return;
+            }
+
             wayfire_view view = wf::wl_surface_to_wayfire_view(event->surface->resource);
             if (!view)
             {
@@ -100,6 +117,26 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
                 return;
             }
 
+            // unset any previously saved view
+            if (last_view)
+            {
+                last_view->disconnect(&on_view_unmapped);
+                last_view->disconnect(&on_view_deactivated);
+                last_view = nullptr;
+            }
+
+            wayfire_view view = token->surface ? wf::wl_surface_to_wayfire_view(
+                token->surface->resource) : nullptr;
+            if (view)
+            {
+                last_view = wf::toplevel_cast(view); // might return nullptr
+                if (last_view)
+                {
+                    last_view->connect(&on_view_unmapped);
+                    last_view->connect(&on_view_deactivated);
+                }
+            }
+
             // update our token and connect its destroy signal
             last_token = token;
             xdg_activation_token_destroy.disconnect();
@@ -125,14 +162,43 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         }
     };
 
+    wf::signal::connection_t<wf::view_unmapped_signal> on_view_unmapped = [this] (auto)
+    {
+        last_view->disconnect(&on_view_unmapped);
+        last_view->disconnect(&on_view_deactivated);
+        // handle the case when last_view was a dialog that is closed by user interaction
+        last_view = last_view->parent;
+        if (last_view)
+        {
+            last_view->connect(&on_view_unmapped);
+            last_view->connect(&on_view_deactivated);
+        }
+    };
+
+    wf::signal::connection_t<wf::view_activated_state_signal> on_view_deactivated = [this] (auto)
+    {
+        if (last_view->activated)
+        {
+            // could be a spurious event, e.g. activating the parent
+            // view after closing a dialog
+            return;
+        }
+
+        last_view->disconnect(&on_view_unmapped);
+        last_view->disconnect(&on_view_deactivated);
+        last_view = nullptr;
+    };
+
     struct wlr_xdg_activation_v1 *xdg_activation;
     wf::wl_listener_wrapper xdg_activation_request_activate;
     wf::wl_listener_wrapper xdg_activation_new_token;
     wf::wl_listener_wrapper xdg_activation_token_destroy;
     struct wlr_xdg_activation_token_v1 *last_token = nullptr;
+    wayfire_toplevel_view last_view = nullptr; // view that created the token
 
     wf::option_wrapper_t<bool> check_surface{"xdg-activation/check_surface"};
     wf::option_wrapper_t<bool> only_last_token{"xdg-activation/only_last_request"};
+    wf::option_wrapper_t<bool> prevent_focus_stealing{"xdg-activation/focus_stealing_prevention"};
     wf::option_wrapper_t<int> timeout{"xdg-activation/timeout"};
 };
 

From 4a539bab195ea9818bbead0e50180b5f1af3b7cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sat, 12 Apr 2025 18:06:14 +0200
Subject: [PATCH 02/10] core, wm: add an option whether newly mapped views
 should be focused

---
 metadata/core.xml                  | 5 +++++
 src/api/wayfire/window-manager.hpp | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/metadata/core.xml b/metadata/core.xml
index 6bb03af7d..7a8e13e82 100644
--- a/metadata/core.xml
+++ b/metadata/core.xml
@@ -93,6 +93,11 @@
 			<_long>Whether to pass buttons through to the client when switching the focus via clicking</_long>
 			<default>true</default>
 		</option>
+		<option name="focus_on_map" type="bool">
+			<_short>Focus newly opened views</_short>
+			<_long>If unset, newly opened views will only be focused by using the xdg-activation protocol.</_long>
+			<default>true</default>
+		</option>
 		<option name="exit" type="key">
 			<_short>Wayfire Shutdown</_short>
 			<_long>Calls the shutdown routines for wayfire.</_long>
diff --git a/src/api/wayfire/window-manager.hpp b/src/api/wayfire/window-manager.hpp
index 0a0f6df11..ed42ec3df 100644
--- a/src/api/wayfire/window-manager.hpp
+++ b/src/api/wayfire/window-manager.hpp
@@ -12,6 +12,11 @@ class window_manager_t
   public:
     virtual ~window_manager_t() = default;
 
+    /**
+     * Option that sets whether newly mapped views get focus by default.
+     */
+    wf::option_wrapper_t<bool> focus_on_map{"core/focus_on_map"};
+
     /**
      * Update the remembered last windowed geometry.
      *

From c88d6a6b12f55f08770b58f703d04424e1713e2c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sat, 12 Apr 2025 18:07:46 +0200
Subject: [PATCH 03/10] xdg-shell, xwayland: do not focus newly mapped
 toplevels if the corresponding option is not set

---
 src/view/xdg-shell/xdg-toplevel-view.cpp     | 14 +++++++++++++-
 src/view/xwayland/xwayland-toplevel-view.hpp | 13 ++++++++++++-
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/src/view/xdg-shell/xdg-toplevel-view.cpp b/src/view/xdg-shell/xdg-toplevel-view.cpp
index c042ac7fd..2040d4ddc 100644
--- a/src/view/xdg-shell/xdg-toplevel-view.cpp
+++ b/src/view/xdg-shell/xdg-toplevel-view.cpp
@@ -310,7 +310,19 @@ void wf::xdg_toplevel_view_t::map()
     adjust_view_output_on_map(this);
 
     xdg_toplevel_view_base_t::map();
-    wf::get_core().default_wm->focus_request(self());
+
+    /* We only focus a newly mapped view if the corresponding option is
+     * set or if there is no currently active view. */
+    auto active_view = wf::get_core().seat->get_active_view();
+    if (active_view && (active_view->role == wf::VIEW_ROLE_DESKTOP_ENVIRONMENT))
+    {
+        active_view = nullptr;
+    }
+
+    if (wf::get_core().default_wm->focus_on_map || (active_view == nullptr))
+    {
+        wf::get_core().default_wm->focus_request(self());
+    }
 
     /* Might trigger repositioning */
     set_toplevel_parent(this->parent);
diff --git a/src/view/xwayland/xwayland-toplevel-view.hpp b/src/view/xwayland/xwayland-toplevel-view.hpp
index 2f7252c58..52dc47583 100644
--- a/src/view/xwayland/xwayland-toplevel-view.hpp
+++ b/src/view/xwayland/xwayland-toplevel-view.hpp
@@ -444,7 +444,18 @@ class wayfire_xwayland_view : public wf::toplevel_view_interface_t, public wayfi
 
         if (wants_focus)
         {
-            wf::get_core().default_wm->focus_request(self());
+            /* We only focus a newly mapped view if the corresponding option is
+             * set or if there is no currently active view. */
+            auto active_view = wf::get_core().seat->get_active_view();
+            if (active_view && (active_view->role == wf::VIEW_ROLE_DESKTOP_ENVIRONMENT))
+            {
+                active_view = nullptr;
+            }
+
+            if (wf::get_core().default_wm->focus_on_map || (active_view == nullptr))
+            {
+                wf::get_core().default_wm->focus_request(self());
+            }
         }
 
         /* Might trigger repositioning */

From 9fb3d235f4983c4df1400f710dd69dbddd825c65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sat, 12 Apr 2025 18:08:15 +0200
Subject: [PATCH 04/10] xdg-activation: focus newly mapped toplevels with a
 valid token

This is necessary as some apps will send the "activate" request before their view is mapped.
---
 plugins/protocols/xdg-activation.cpp | 57 +++++++++++++++++++++++-----
 1 file changed, 47 insertions(+), 10 deletions(-)

diff --git a/plugins/protocols/xdg-activation.cpp b/plugins/protocols/xdg-activation.cpp
index 5926b19af..0e346db96 100644
--- a/plugins/protocols/xdg-activation.cpp
+++ b/plugins/protocols/xdg-activation.cpp
@@ -35,6 +35,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         xdg_activation_request_activate.disconnect();
         xdg_activation_new_token.disconnect();
         xdg_activation_token_destroy.disconnect();
+        on_view_mapped.disconnect();
         last_token = nullptr;
         if (last_view)
         {
@@ -70,33 +71,49 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
 
             last_token = nullptr; // avoid reusing the same token
 
-            if (last_view)
-            {
-                last_view->disconnect(&on_view_unmapped);
-                last_view->disconnect(&on_view_deactivated);
-                last_view = nullptr;
-            } else if (prevent_focus_stealing)
+            if (prevent_focus_stealing && !last_view)
             {
                 LOGI("Denying focus request, requesting view has been deactivated");
                 return;
             }
 
+            bool should_focus = true;
             wayfire_view view = wf::wl_surface_to_wayfire_view(event->surface->resource);
             if (!view)
             {
                 LOGE("Could not get view");
-                return;
+                should_focus = false;
             }
 
             auto toplevel = wf::toplevel_cast(view);
             if (!toplevel)
             {
                 LOGE("Could not get toplevel view");
-                return;
+                should_focus = false;
+            }
+
+            if (should_focus)
+            {
+                if (toplevel->toplevel()->current().mapped)
+                {
+                    LOGD("Activating view");
+                    wf::get_core().default_wm->focus_request(toplevel);
+                } else
+                {
+                    /* This toplevel is not mapped yet, we want to focus it
+                     * when it it first mapped. */
+                    on_view_mapped.disconnect();
+                    view->connect(&on_view_mapped);
+                    return; // avoid disconnecting last_view's signals
+                }
             }
 
-            LOGD("Activating view");
-            wf::get_core().default_wm->focus_request(toplevel);
+            if (last_view)
+            {
+                last_view->disconnect(&on_view_unmapped);
+                last_view->disconnect(&on_view_deactivated);
+                last_view = nullptr;
+            }
         });
 
         xdg_activation_new_token.set_callback([this] (void *data)
@@ -189,6 +206,26 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         last_view = nullptr;
     };
 
+    wf::signal::connection_t<wf::view_mapped_signal> on_view_mapped = [this] (auto signal)
+    {
+        signal->view->disconnect(&on_view_mapped);
+
+        // re-check focus stealing prevention
+        if (last_view)
+        {
+            last_view->disconnect(&on_view_unmapped);
+            last_view->disconnect(&on_view_deactivated);
+            last_view = nullptr;
+        } else if (prevent_focus_stealing)
+        {
+            LOGI("Denying focus request, requesting view has been deactivated");
+            return;
+        }
+
+        LOGD("Activating view");
+        wf::get_core().default_wm->focus_request(signal->view);
+    };
+
     struct wlr_xdg_activation_v1 *xdg_activation;
     wf::wl_listener_wrapper xdg_activation_request_activate;
     wf::wl_listener_wrapper xdg_activation_new_token;

From 04e5dbfba33ee5a699d5c6230b484a343ca5085d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sat, 12 Apr 2025 19:41:25 +0200
Subject: [PATCH 05/10] core: emit a signal before running a command that
 allows plugins to add environment variables

---
 src/api/wayfire/signal-definitions.hpp | 15 +++++++++++++++
 src/core/core.cpp                      |  8 ++++++++
 2 files changed, 23 insertions(+)

diff --git a/src/api/wayfire/signal-definitions.hpp b/src/api/wayfire/signal-definitions.hpp
index 800068171..18653ce90 100644
--- a/src/api/wayfire/signal-definitions.hpp
+++ b/src/api/wayfire/signal-definitions.hpp
@@ -203,6 +203,21 @@ struct idle_inhibit_changed_signal
     bool inhibit;
 };
 
+/**
+ * on: core
+ * when: before running a command in compositor_core_t::run().
+ *   Plugins can listen to this signal and add environment variables to
+ *   set in env.
+ */
+struct command_run_signal
+{
+    const std::string& command;
+    std::vector<std::pair<std::string, std::string>> env;
+
+    command_run_signal(const std::string& cmd) : command(cmd)
+    {}
+};
+
 /**
  * on: output, core(output-)
  * when: Immediately after the output becomes focused.
diff --git a/src/core/core.cpp b/src/core/core.cpp
index 10aae38cb..aeb6961f2 100644
--- a/src/core/core.cpp
+++ b/src/core/core.cpp
@@ -524,6 +524,9 @@ pid_t wf::compositor_core_impl_t::run(std::string command)
         return 0;
     }
 
+    wf::command_run_signal signal(command);
+    wf::get_core().emit(&signal);
+
     /* The following is a "hack" for disowning the child processes,
      * otherwise they will simply stay as zombie processes */
     pid_t pid = fork();
@@ -545,6 +548,11 @@ pid_t wf::compositor_core_impl_t::run(std::string command)
             }
 
 #endif
+            for (const auto& var : signal.env)
+            {
+                setenv(var.first.c_str(), var.second.c_str(), 1);
+            }
+
             if (discard_command_output)
             {
                 int dev_null = open("/dev/null", O_WRONLY);

From 51e6e39e2927b08d03e250be6d3814410a95848f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sat, 12 Apr 2025 19:45:54 +0200
Subject: [PATCH 06/10] xdg-activation: generate activation tokens and pass
 them to commands run by Wayfire

This is required for them to activate if focusing newly mapped views by default is disabled.
---
 plugins/protocols/xdg-activation.cpp | 80 +++++++++++++++++++++++++---
 1 file changed, 72 insertions(+), 8 deletions(-)

diff --git a/plugins/protocols/xdg-activation.cpp b/plugins/protocols/xdg-activation.cpp
index 0e346db96..b7c40e664 100644
--- a/plugins/protocols/xdg-activation.cpp
+++ b/plugins/protocols/xdg-activation.cpp
@@ -8,6 +8,7 @@
 #include <wayfire/nonstd/wlroots-full.hpp>
 #include <wayfire/window-manager.hpp>
 #include <wayfire/util.hpp>
+#include <wayfire/seat.hpp>
 #include "config.h"
 
 class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
@@ -28,6 +29,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
 
         xdg_activation_request_activate.connect(&xdg_activation->events.request_activate);
         xdg_activation_new_token.connect(&xdg_activation->events.new_token);
+        wf::get_core().connect(&on_run_command);
     }
 
     void fini() override
@@ -35,6 +37,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         xdg_activation_request_activate.disconnect();
         xdg_activation_new_token.disconnect();
         xdg_activation_token_destroy.disconnect();
+        xdg_activation_token_self_destroy.disconnect();
         on_view_mapped.disconnect();
         last_token = nullptr;
         if (last_view)
@@ -43,6 +46,8 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             last_view->disconnect(&on_view_deactivated);
             last_view = nullptr;
         }
+
+        wf::get_core().disconnect(&on_run_command);
     }
 
     bool is_unloadable() override
@@ -57,19 +62,23 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         {
             auto event = static_cast<const struct wlr_xdg_activation_v1_request_activate_event*>(data);
 
-            if (!event->token->seat)
+            if (event->token != last_self_token)
             {
-                LOGI("Denying focus request, token was rejected at creation");
-                return;
-            }
+                if (!event->token->seat)
+                {
+                    LOGI("Denying focus request, token was rejected at creation");
+                    return;
+                }
 
-            if (only_last_token && (event->token != last_token))
-            {
-                LOGI("Denying focus request, token is expired");
-                return;
+                if (only_last_token && (event->token != last_token))
+                {
+                    LOGI("Denying focus request, token is expired");
+                    return;
+                }
             }
 
             last_token = nullptr; // avoid reusing the same token
+            last_self_token = nullptr;
 
             if (prevent_focus_stealing && !last_view)
             {
@@ -167,6 +176,13 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             xdg_activation_token_destroy.disconnect();
         });
 
+        xdg_activation_token_self_destroy.set_callback([this] (void *data)
+        {
+            last_self_token = nullptr;
+
+            xdg_activation_token_self_destroy.disconnect();
+        });
+
         timeout.set_callback(timeout_changed);
     }
 
@@ -226,11 +242,59 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         wf::get_core().default_wm->focus_request(signal->view);
     };
 
+    wf::signal::connection_t<wf::command_run_signal> on_run_command = [this] (auto signal)
+    {
+        if (wf::get_core().default_wm->focus_on_map)
+        {
+            // no need to do anything if views are focused anyway
+            return;
+        }
+
+        if (last_self_token)
+        {
+            // TODO: invalidate our last token !
+            last_self_token = nullptr;
+        }
+
+        auto active_view = wf::get_core().seat->get_active_view();
+        if (active_view && (active_view->role == wf::VIEW_ROLE_DESKTOP_ENVIRONMENT))
+        {
+            active_view = nullptr;
+        }
+
+        auto active_toplevel = active_view ? wf::toplevel_cast(active_view) : nullptr;
+
+        if (!active_toplevel)
+        {
+            // if there is no active view, we don't need a token
+            return;
+        }
+
+        if (last_view)
+        {
+            // TODO: we need a separate last_view actually !
+            last_view->disconnect(&on_view_unmapped);
+            last_view->disconnect(&on_view_deactivated);
+        }
+
+        last_view = active_toplevel;
+        last_view->connect(&on_view_unmapped);
+        last_view->connect(&on_view_deactivated);
+        last_self_token = wlr_xdg_activation_token_v1_create(xdg_activation);
+        xdg_activation_token_self_destroy.disconnect();
+        xdg_activation_token_self_destroy.connect(&last_self_token->events.destroy);
+        const char *token_id = wlr_xdg_activation_token_v1_get_name(last_self_token);
+        signal->env.emplace_back("XDG_ACTIVATION_TOKEN", token_id);
+        signal->env.emplace_back("DESKTOP_STARTUP_ID", token_id);
+    };
+
     struct wlr_xdg_activation_v1 *xdg_activation;
     wf::wl_listener_wrapper xdg_activation_request_activate;
     wf::wl_listener_wrapper xdg_activation_new_token;
     wf::wl_listener_wrapper xdg_activation_token_destroy;
+    wf::wl_listener_wrapper xdg_activation_token_self_destroy;
     struct wlr_xdg_activation_token_v1 *last_token = nullptr;
+    struct wlr_xdg_activation_token_v1 *last_self_token = nullptr;
     wayfire_toplevel_view last_view = nullptr; // view that created the token
 
     wf::option_wrapper_t<bool> check_surface{"xdg-activation/check_surface"};

From 889e3784f5074fee9493ab8f8d8b774a58357fbf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sun, 13 Apr 2025 13:15:48 +0200
Subject: [PATCH 07/10] xdg-shell, xwayland: do not bring to front newly mapped
 toplevels

---
 src/view/xdg-shell/xdg-toplevel-view.cpp     | 3 +++
 src/view/xwayland/xwayland-toplevel-view.hpp | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/view/xdg-shell/xdg-toplevel-view.cpp b/src/view/xdg-shell/xdg-toplevel-view.cpp
index 2040d4ddc..f4e77d2ff 100644
--- a/src/view/xdg-shell/xdg-toplevel-view.cpp
+++ b/src/view/xdg-shell/xdg-toplevel-view.cpp
@@ -322,6 +322,9 @@ void wf::xdg_toplevel_view_t::map()
     if (wf::get_core().default_wm->focus_on_map || (active_view == nullptr))
     {
         wf::get_core().default_wm->focus_request(self());
+    } else if (active_view)
+    {
+        wf::view_bring_to_front(active_view);
     }
 
     /* Might trigger repositioning */
diff --git a/src/view/xwayland/xwayland-toplevel-view.hpp b/src/view/xwayland/xwayland-toplevel-view.hpp
index 52dc47583..7eb89d529 100644
--- a/src/view/xwayland/xwayland-toplevel-view.hpp
+++ b/src/view/xwayland/xwayland-toplevel-view.hpp
@@ -455,6 +455,9 @@ class wayfire_xwayland_view : public wf::toplevel_view_interface_t, public wayfi
             if (wf::get_core().default_wm->focus_on_map || (active_view == nullptr))
             {
                 wf::get_core().default_wm->focus_request(self());
+            } else if (active_view)
+            {
+                wf::view_bring_to_front(active_view);
             }
         }
 

From 67ceac85d3c6989bca93df246d1663e771da185a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Mon, 21 Apr 2025 17:24:17 +0200
Subject: [PATCH 08/10] xdg-shell, xwayland: always focus dialogs on map if
 parent is focused

Dialogs are identified as a view with a parent.

This commit also moves shared code between xdg-shell and xwayland to a common location (toplevel_view_interface_t::focus_toplevel_on_map())
---
 src/api/wayfire/toplevel-view.hpp            | 11 +++++++
 src/view/toplevel-view.cpp                   | 30 ++++++++++++++++++++
 src/view/xdg-shell/xdg-toplevel-view.cpp     | 16 +----------
 src/view/xwayland/xwayland-toplevel-view.hpp | 16 +----------
 4 files changed, 43 insertions(+), 30 deletions(-)

diff --git a/src/api/wayfire/toplevel-view.hpp b/src/api/wayfire/toplevel-view.hpp
index d40688e27..49ed29ca2 100644
--- a/src/api/wayfire/toplevel-view.hpp
+++ b/src/api/wayfire/toplevel-view.hpp
@@ -203,6 +203,17 @@ class toplevel_view_interface_t : public virtual wf::view_interface_t
      * This function is useful for view implementations only.
      */
     void set_toplevel(std::shared_ptr<wf::toplevel_t> toplevel);
+
+    /**
+     * Potentially focus this view on first map. Newly mapped views are
+     * focused if either:
+     *  - the "core/focus_on_map" option is set
+     *  - no toplevel view is currently focused (i.e. no view is focused
+     *      or the currently focused view has role VIEW_ROLE_DESKTOP_ENVIRONMENT)
+     *  - the newly mapped view is a dialog (i.e. has a non-null parent)
+     *      and its parent is focused
+     */
+    void focus_toplevel_on_map();
 };
 
 inline wayfire_toplevel_view toplevel_cast(wayfire_view view)
diff --git a/src/view/toplevel-view.cpp b/src/view/toplevel-view.cpp
index 5f91f5507..3fd56f325 100644
--- a/src/view/toplevel-view.cpp
+++ b/src/view/toplevel-view.cpp
@@ -8,6 +8,7 @@
 #include <wayfire/window-manager.hpp>
 #include <wayfire/txn/transaction-manager.hpp>
 #include <wayfire/seat.hpp>
+#include <wayfire/view-helpers.hpp>
 #include "view-impl.hpp"
 #include "wayfire/core.hpp"
 #include "wayfire/scene.hpp"
@@ -329,6 +330,35 @@ void wf::toplevel_view_interface_t::set_toplevel(
     priv->toplevel = toplevel;
 }
 
+void wf::toplevel_view_interface_t::focus_toplevel_on_map()
+{
+    /* We only focus a newly mapped view if the corresponding option is
+     * set or if there is no currently active view. */
+    wayfire_view active_view = nullptr;
+    bool should_focus = wf::get_core().default_wm->focus_on_map;
+    if (!should_focus)
+    {
+        active_view = wf::get_core().seat->get_active_view();
+        if (active_view && (active_view->role == wf::VIEW_ROLE_DESKTOP_ENVIRONMENT))
+        {
+            active_view = nullptr;
+        }
+
+        if (!active_view || (active_view == this->parent))
+        {
+            should_focus = true;
+        }
+    }
+
+    if (should_focus)
+    {
+        wf::get_core().default_wm->focus_request(self());
+    } else if (active_view)
+    {
+        wf::view_bring_to_front(active_view);
+    }
+}
+
 wayfire_toplevel_view wf::find_view_for_toplevel(
     std::shared_ptr<wf::toplevel_t> toplevel)
 {
diff --git a/src/view/xdg-shell/xdg-toplevel-view.cpp b/src/view/xdg-shell/xdg-toplevel-view.cpp
index f4e77d2ff..7dec8efc1 100644
--- a/src/view/xdg-shell/xdg-toplevel-view.cpp
+++ b/src/view/xdg-shell/xdg-toplevel-view.cpp
@@ -311,21 +311,7 @@ void wf::xdg_toplevel_view_t::map()
 
     xdg_toplevel_view_base_t::map();
 
-    /* We only focus a newly mapped view if the corresponding option is
-     * set or if there is no currently active view. */
-    auto active_view = wf::get_core().seat->get_active_view();
-    if (active_view && (active_view->role == wf::VIEW_ROLE_DESKTOP_ENVIRONMENT))
-    {
-        active_view = nullptr;
-    }
-
-    if (wf::get_core().default_wm->focus_on_map || (active_view == nullptr))
-    {
-        wf::get_core().default_wm->focus_request(self());
-    } else if (active_view)
-    {
-        wf::view_bring_to_front(active_view);
-    }
+    focus_toplevel_on_map();
 
     /* Might trigger repositioning */
     set_toplevel_parent(this->parent);
diff --git a/src/view/xwayland/xwayland-toplevel-view.hpp b/src/view/xwayland/xwayland-toplevel-view.hpp
index 7eb89d529..70c6d8060 100644
--- a/src/view/xwayland/xwayland-toplevel-view.hpp
+++ b/src/view/xwayland/xwayland-toplevel-view.hpp
@@ -444,21 +444,7 @@ class wayfire_xwayland_view : public wf::toplevel_view_interface_t, public wayfi
 
         if (wants_focus)
         {
-            /* We only focus a newly mapped view if the corresponding option is
-             * set or if there is no currently active view. */
-            auto active_view = wf::get_core().seat->get_active_view();
-            if (active_view && (active_view->role == wf::VIEW_ROLE_DESKTOP_ENVIRONMENT))
-            {
-                active_view = nullptr;
-            }
-
-            if (wf::get_core().default_wm->focus_on_map || (active_view == nullptr))
-            {
-                wf::get_core().default_wm->focus_request(self());
-            } else if (active_view)
-            {
-                wf::view_bring_to_front(active_view);
-            }
+            focus_toplevel_on_map();
         }
 
         /* Might trigger repositioning */

From 50f8acccb14069fb50ec4e048d774d01424f5a89 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sun, 15 Jun 2025 21:05:15 +0800
Subject: [PATCH 09/10] add a note

---
 plugins/protocols/xdg-activation.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/plugins/protocols/xdg-activation.cpp b/plugins/protocols/xdg-activation.cpp
index b7c40e664..78bcd531e 100644
--- a/plugins/protocols/xdg-activation.cpp
+++ b/plugins/protocols/xdg-activation.cpp
@@ -156,6 +156,9 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             if (view)
             {
                 last_view = wf::toplevel_cast(view); // might return nullptr
+                //!! does not work for:
+                // (1) layer-shell views
+                // (2) (some) menus
                 if (last_view)
                 {
                     last_view->connect(&on_view_unmapped);

From 418b745d188d979c66dc4648236b168f8251e686 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kondor=20D=C3=A1niel?= <kondor.dani@gmail.com>
Date: Sun, 22 Jun 2025 23:39:39 +0800
Subject: [PATCH 10/10] attempt to track popups

---
 plugins/protocols/xdg-activation.cpp | 87 ++++++++++++++++++----------
 1 file changed, 58 insertions(+), 29 deletions(-)

diff --git a/plugins/protocols/xdg-activation.cpp b/plugins/protocols/xdg-activation.cpp
index 78bcd531e..e8bbbf785 100644
--- a/plugins/protocols/xdg-activation.cpp
+++ b/plugins/protocols/xdg-activation.cpp
@@ -43,7 +43,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         if (last_view)
         {
             last_view->disconnect(&on_view_unmapped);
-            last_view->disconnect(&on_view_deactivated);
+            // last_view->disconnect(&on_view_deactivated);
             last_view = nullptr;
         }
 
@@ -80,7 +80,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             last_token = nullptr; // avoid reusing the same token
             last_self_token = nullptr;
 
-            if (prevent_focus_stealing && !last_view)
+            if (prevent_focus_stealing && (!last_view || last_view != wf::get_core().seat->get_active_view()))
             {
                 LOGI("Denying focus request, requesting view has been deactivated");
                 return;
@@ -120,7 +120,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             if (last_view)
             {
                 last_view->disconnect(&on_view_unmapped);
-                last_view->disconnect(&on_view_deactivated);
+                // last_view->disconnect(&on_view_deactivated);
                 last_view = nullptr;
             }
         });
@@ -147,7 +147,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             if (last_view)
             {
                 last_view->disconnect(&on_view_unmapped);
-                last_view->disconnect(&on_view_deactivated);
+                // last_view->disconnect(&on_view_deactivated);
                 last_view = nullptr;
             }
 
@@ -155,15 +155,10 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
                 token->surface->resource) : nullptr;
             if (view)
             {
-                last_view = wf::toplevel_cast(view); // might return nullptr
-                //!! does not work for:
-                // (1) layer-shell views
-                // (2) (some) menus
-                if (last_view)
-                {
-                    last_view->connect(&on_view_unmapped);
-                    last_view->connect(&on_view_deactivated);
-                }
+                last_view = view;
+                last_view->connect(&on_view_unmapped);
+                LOGI("New token for view: ", view.get());
+                // last_view->connect(&on_view_deactivated);
             }
 
             // update our token and connect its destroy signal
@@ -201,16 +196,40 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
     wf::signal::connection_t<wf::view_unmapped_signal> on_view_unmapped = [this] (auto)
     {
         last_view->disconnect(&on_view_unmapped);
-        last_view->disconnect(&on_view_deactivated);
+        // last_view->disconnect(&on_view_deactivated);
+        LOGI("View closed: ", last_view.get());
+        
         // handle the case when last_view was a dialog that is closed by user interaction
-        last_view = last_view->parent;
+        auto toplevel = wf::toplevel_cast(last_view);
+        if (toplevel)
+        {
+            last_view = toplevel->parent;
+            LOGI("Setting parent: ", last_view.get());
+        } else
+        {
+            //!! does not work, it is already NULL when this is called
+            auto surface = last_view->get_wlr_surface();
+            auto popup = surface ? wlr_xdg_popup_try_from_wlr_surface (surface) : nullptr;
+            if (popup && popup->parent)
+            {
+                last_view = wf::wl_surface_to_wayfire_view (popup->parent->resource);
+                LOGI("Setting parent (from xdg-popup): ", last_view.get());
+            } else
+            {
+                //!! TODO: XWayland popups?
+                last_view = nullptr;
+                LOGI("No parent");
+            }
+        }
+
         if (last_view)
         {
             last_view->connect(&on_view_unmapped);
-            last_view->connect(&on_view_deactivated);
+            // last_view->connect(&on_view_deactivated);
         }
     };
 
+/*
     wf::signal::connection_t<wf::view_activated_state_signal> on_view_deactivated = [this] (auto)
     {
         if (last_view->activated)
@@ -224,25 +243,35 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         last_view->disconnect(&on_view_deactivated);
         last_view = nullptr;
     };
+*/
 
     wf::signal::connection_t<wf::view_mapped_signal> on_view_mapped = [this] (auto signal)
     {
         signal->view->disconnect(&on_view_mapped);
 
+        bool should_focus = true;
+
         // re-check focus stealing prevention
+        if (prevent_focus_stealing)
+        {
+            if (!last_view || last_view != wf::get_core().seat->get_active_view())
+            {
+                LOGI("Denying focus request, requesting view has been deactivated");
+                should_focus = false;
+            }
+        }
         if (last_view)
         {
             last_view->disconnect(&on_view_unmapped);
-            last_view->disconnect(&on_view_deactivated);
+            // last_view->disconnect(&on_view_deactivated);
             last_view = nullptr;
-        } else if (prevent_focus_stealing)
-        {
-            LOGI("Denying focus request, requesting view has been deactivated");
-            return;
         }
 
-        LOGD("Activating view");
-        wf::get_core().default_wm->focus_request(signal->view);
+        if (should_focus)
+        {
+            LOGD("Activating view");
+            wf::get_core().default_wm->focus_request(signal->view);
+        }
     };
 
     wf::signal::connection_t<wf::command_run_signal> on_run_command = [this] (auto signal)
@@ -265,9 +294,9 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             active_view = nullptr;
         }
 
-        auto active_toplevel = active_view ? wf::toplevel_cast(active_view) : nullptr;
+        // auto active_toplevel = active_view ? wf::toplevel_cast(active_view) : nullptr;
 
-        if (!active_toplevel)
+        if (!active_view)
         {
             // if there is no active view, we don't need a token
             return;
@@ -277,12 +306,12 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
         {
             // TODO: we need a separate last_view actually !
             last_view->disconnect(&on_view_unmapped);
-            last_view->disconnect(&on_view_deactivated);
+            // last_view->disconnect(&on_view_deactivated);
         }
 
-        last_view = active_toplevel;
+        last_view = active_view;
         last_view->connect(&on_view_unmapped);
-        last_view->connect(&on_view_deactivated);
+        // last_view->connect(&on_view_deactivated);
         last_self_token = wlr_xdg_activation_token_v1_create(xdg_activation);
         xdg_activation_token_self_destroy.disconnect();
         xdg_activation_token_self_destroy.connect(&last_self_token->events.destroy);
@@ -298,7 +327,7 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
     wf::wl_listener_wrapper xdg_activation_token_self_destroy;
     struct wlr_xdg_activation_token_v1 *last_token = nullptr;
     struct wlr_xdg_activation_token_v1 *last_self_token = nullptr;
-    wayfire_toplevel_view last_view = nullptr; // view that created the token
+    wayfire_view last_view = nullptr; // view that created the token
 
     wf::option_wrapper_t<bool> check_surface{"xdg-activation/check_surface"};
     wf::option_wrapper_t<bool> only_last_token{"xdg-activation/only_last_request"};