Set enableHighAccuracy=true when requesting position#89
Merged
otherdaniel merged 1 commit intoWICG:mainfrom Feb 4, 2026
Merged
Set enableHighAccuracy=true when requesting position#89otherdaniel merged 1 commit intoWICG:mainfrom
otherdaniel merged 1 commit intoWICG:mainfrom
Conversation
Collaborator
Author
|
@otherdaniel PTAL |
otherdaniel
approved these changes
Feb 4, 2026
Collaborator
otherdaniel
left a comment
otherdaniel
left a comment
There was a problem hiding this comment.
Thanks, looks good!
PS: I apparently inadvertently committed the rendererd .html. I'll delete it again. That said, while it's in there it better be up to date. :)
geolocation-element.bs
Outdated
| positionError argument. | ||
| 1. [=Dispatch onlocation=] to [=this=]. | ||
| 1. Let |positionOptions| be «[]» | ||
| 1. Let |positionOptions| be a new {{PositionOptions}} with |
Collaborator
There was a problem hiding this comment.
fyi, since {{PositionOptions}} is a dictionary, a more idiomatic way to write this would have been:
«[ "{{PositionOptions/enableHighAccuracy}}" → true ]»
(ref: https://infra.spec.whatwg.org/#maps)
Either way is fine, though.
antosart
force-pushed
the
enable-high-accuracy
branch
from
1c13431 to
3fb54b7
Compare
antosart
force-pushed
the
enable-high-accuracy
branch
from
3fb54b7 to
b9c3404
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2026
SHA: 4e2f8a6 Reason: push, by otherdaniel Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2026
SHA: 4e2f8a6 Reason: push, by otherdaniel Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to otherdaniel/PEPC
that referenced
this pull request
Feb 4, 2026
SHA: 4e2f8a6 Reason: push, by otherdaniel Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to otherdaniel/PEPC
that referenced
this pull request
Feb 4, 2026
SHA: 4e2f8a6 Reason: push, by otherdaniel Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoding enableHighAccuracy=false can result in a position which has lower precision. Since it is not possible to change that, this means that the element cannot deliver the same position quality of the Geolocation API, which is unfortunate. It seems better to always set enableHighAccuracy=true instead.