From 59d944b4c8a927ba13d568891e8fc04233668e44 Mon Sep 17 00:00:00 2001 From: Alexander Rudavka Date: Sun, 2 Aug 2020 16:20:40 -0400 Subject: [PATCH 1/3] feat: add hiding keyboard on scrollViewDidScroll(:) --- .../View Controllers/Learn/PriceCheckViewController.swift | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift b/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift index 71e08aa..9df50fb 100644 --- a/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift +++ b/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift @@ -84,6 +84,14 @@ extension PriceCheckViewController: UISearchBarDelegate { } } +// MARK: - UIScrollViewDelegate + +extension PriceCheckViewController { + override func scrollViewDidScroll(_ scrollView: UIScrollView) { + searchBar.resignFirstResponder() + } +} + extension PriceCheckViewController: PriceCheckControllerDelegate { func resultsDidChange() { tableView.reloadData() From 2495a71fd40e109f3f2bbf52fd165e95eb8cd102 Mon Sep 17 00:00:00 2001 From: Alexander Rudavka Date: Sun, 2 Aug 2020 16:41:27 -0400 Subject: [PATCH 2/3] feat: hide keyboard on search button clicked --- .../View Controllers/Learn/PriceCheckViewController.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift b/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift index 9df50fb..e3bdea9 100644 --- a/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift +++ b/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift @@ -82,6 +82,10 @@ extension PriceCheckViewController: UISearchBarDelegate { func searchBar(_ searchBar: UISearchBar, textDidChange searchText: String) { controller.updateSearchText(searchText) } + + func searchBarSearchButtonClicked(_ searchBar: UISearchBar) { + searchBar.resignFirstResponder() + } } // MARK: - UIScrollViewDelegate From b1d1a7eae45bb41c12b0ae80b807d5e24e611439 Mon Sep 17 00:00:00 2001 From: Alexander Rudavka Date: Tue, 4 Aug 2020 19:34:59 -0400 Subject: [PATCH 3/3] ref: replace ...didScroll() with ...willBeginDragging() --- .../View Controllers/Learn/PriceCheckViewController.swift | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift b/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift index e3bdea9..31b8419 100644 --- a/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift +++ b/iOS/BattleBuddy/Source/View/View Controllers/Learn/PriceCheckViewController.swift @@ -91,8 +91,10 @@ extension PriceCheckViewController: UISearchBarDelegate { // MARK: - UIScrollViewDelegate extension PriceCheckViewController { - override func scrollViewDidScroll(_ scrollView: UIScrollView) { - searchBar.resignFirstResponder() + override func scrollViewWillBeginDragging(_ scrollView: UIScrollView) { + if searchBar.isFirstResponder { + searchBar.resignFirstResponder() + } } }