From 6dff19cfc08c2d9042b01530e2cd740a65875d0e Mon Sep 17 00:00:00 2001 From: marcos-albornoz Date: Sat, 6 Sep 2025 01:17:42 -0600 Subject: [PATCH 1/2] Impr: Fix intermittent failure in TestRenewCertificate --- pkg/venafi/cloud/connector_test.go | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/pkg/venafi/cloud/connector_test.go b/pkg/venafi/cloud/connector_test.go index 0d4a389b..82d5c71f 100644 --- a/pkg/venafi/cloud/connector_test.go +++ b/pkg/venafi/cloud/connector_test.go @@ -695,10 +695,24 @@ func renewCertificateRequest(t *testing.T, conn *Connector, renewalRequest *cert t.Logf("requested renewal for %s, will pickup by %s", previousPickupID, reqId) - certStatus, err := conn.getCertificateStatus(reqId) - if err != nil { - t.Fatal(err) + var certStatus *certificateStatus + count = 0 + //trying by 3 times to get issued state + for { + count++ + certStatus, err = conn.getCertificateStatus(reqId) + + if err != nil { + t.Fatal(err) + } + + if certStatus.Status == "ISSUED" || count > 3 { + break + } + + time.Sleep(3 * time.Second) } + certificateId := certStatus.CertificateIdsList[0] managedCert, err := conn.getCertificate(certificateId) if err != nil { From a41c5f7169f8d32505c1870b84e9bc0a2859c6fd Mon Sep 17 00:00:00 2001 From: marcos-albornoz Date: Sat, 6 Sep 2025 01:33:16 -0600 Subject: [PATCH 2/2] Impr: Set 5 sec as time sleep for TestRenewCertificate --- pkg/venafi/cloud/connector_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/venafi/cloud/connector_test.go b/pkg/venafi/cloud/connector_test.go index 82d5c71f..71976dfe 100644 --- a/pkg/venafi/cloud/connector_test.go +++ b/pkg/venafi/cloud/connector_test.go @@ -710,7 +710,7 @@ func renewCertificateRequest(t *testing.T, conn *Connector, renewalRequest *cert break } - time.Sleep(3 * time.Second) + time.Sleep(5 * time.Second) } certificateId := certStatus.CertificateIdsList[0]