Attach Function Question

[Schlappo22]

Hello,

I have been playing around with this library for some time now and improved my code further and further.
One thing that I can't seem to figure out is if there is another way of passing my function to X.attach_function. I have to go implement an extra step, which seems a bit unnecessary. Please see a snip of my example below. Is there a way to get rid of the very repetitive functions void increase_variable_0 etc. and instead pass the increase_variable(0) directly to the X.attach_function

// Increase a variable's value
void increase_variable(int variable_index) {
  if (variables[variable_index][0] < variables[variable_index][1]) {
    variables[variable_index][0] += variables[variable_index][3];
    Serial.print("Increase ");
    Serial.print(variable_index);
    Serial.print(" called");
    Serial.println();
    //Save Input
    EEPROM.put(variables[variable_index][4], variables[variable_index][0]);
    Serial.print(variable_index);
    Serial.print(" saved");
    Serial.print(": ");
    Serial.print(variables[variable_index][0]);
    Serial.print(" in postion ");
    Serial.println(variables[variable_index][4]);
  } else {
    variables[variable_index][0] = variables[variable_index][1];
    Serial.print("Max ");
    Serial.print(variable_index);
    Serial.print(" reached");
    Serial.println();
  }
}

// Decrease a variable's value
void decrease_variable(int variable_index) {
  if (variables[variable_index][0] > variables[variable_index][2]) {
    variables[variable_index][0] -= variables[variable_index][3];
    Serial.print("Decrease ");
    Serial.print(variable_index);
    Serial.print(" called");
    Serial.println();
    //Save Input
    EEPROM.put(variables[variable_index][4], variables[variable_index][0]);
    Serial.print(variable_index);
    Serial.print(" saved");
    Serial.print(": ");
    Serial.print(variables[variable_index][0]);
    Serial.print(" in postion ");
    Serial.print(variables[variable_index][4]);
  } else {
    variables[variable_index][0] = variables[variable_index][2];
    Serial.print("Min ");
    Serial.print(variable_index);
    Serial.print(" reached");
    Serial.println();
  }
}

void increase_variable_0() {
  increase_variable(0);
}

void decrease_variable_0() {
  decrease_variable(0);
}

void increase_variable_1() {
  increase_variable(1);
}

void decrease_variable_1() {
  decrease_variable(1);
}

water_line_1.attach_function(increase, increase_variable_0);
water_line_1.attach_function(decrease, decrease_variable_0);
water_line_2.attach_function(increase, increase_variable_1);
water_line_2.attach_function(decrease, decrease_variable_1);

[VasilKalchev]

Hello @Schlappo22.

I agree, these functions can get repetitive. One workaround would be to get rid of the parameter int variable_index in your functions void increase_variable() and void decrease_variable() and ask the menu object which line is currently focused, that way you can determine which variable should be changed:

void increase_variable() {
  uint8_t focused_line_index = menu.get_focusedLine();

  // Convert the line's index to the variable's index:
  uint8_t variable_index = focused_line_index; // in case they match

  if (variables[variable_index][0] < variables[variable_index][1]) {
  // ...
}

But I don't know if this will be worth it, it's counterintuitive and error prone.

The other way involves improving the library itself. The function pointer used in the library, expects a function with the signature: void func(). It should be possible to change the signature to: void func(void*) and cast the void * inside the user's function. I don't have plans to implement this soon, but if you require this functionality you can fork the repository and experiment with this change.