From aee1a569b23758f174427fa17940c7281643edf8 Mon Sep 17 00:00:00 2001 From: Justin Arulnathan Date: Thu, 17 Sep 2015 22:34:55 +1000 Subject: [PATCH 1/2] attach callbacks according to names passed into attrs --- angular-redactor.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/angular-redactor.js b/angular-redactor.js index 5a106ae..b767bcb 100644 --- a/angular-redactor.js +++ b/angular-redactor.js @@ -37,7 +37,14 @@ scope.$eval(attrs.redactor) : {}, editor; - angular.extend(options, redactorOptions, additionalOptions); + var redactorCallbacks = {}; + if (additionalOptions.hasOwnProperty('callbacks') === true){ + additionalOptions.callbacks.forEach(function(callback){ + redactorCallbacks[callback] = window[callback] + }); + } + + angular.extend(options, redactorOptions, additionalOptions, redactorCallbacks); // prevent collision with the constant values on ChangeCallback var changeCallback = additionalOptions.changeCallback || redactorOptions.changeCallback; @@ -72,4 +79,3 @@ }; }]); })(); - From bed3f08c67d64f64f1f6e94e71744e5e19ead01e Mon Sep 17 00:00:00 2001 From: George Date: Fri, 22 Apr 2016 14:30:02 +1000 Subject: [PATCH 2/2] Allow callback name (eg. 'blurCallback') to be different from the function name attached to window --- angular-redactor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/angular-redactor.js b/angular-redactor.js index b767bcb..6588bdf 100644 --- a/angular-redactor.js +++ b/angular-redactor.js @@ -40,7 +40,7 @@ var redactorCallbacks = {}; if (additionalOptions.hasOwnProperty('callbacks') === true){ additionalOptions.callbacks.forEach(function(callback){ - redactorCallbacks[callback] = window[callback] + redactorCallbacks[callback.type] = window[callback.functionName]; }); }