-
Notifications
You must be signed in to change notification settings - Fork 31
Description
Currently, bannerGen.php only ingests the system name (e.g. usaus) and the banner types (e.g. Bus, AltTrk, etc.). This makes it difficult to determine which banners should be generated and which should be returned as "not external" for certain systems where signage practices vary from route to route.
An example of this behavior would be usatr. The Circle Tour routes in Michigan use internal banners, while most other routes in the system should receive external banners. Currently, we would have to either:
- remove external banners from all Spur and Loop routes in system usatr
- include external banners on the routes that use internal banners (redundant banners)
The ideal solution would be to only exclude banners if region=MI and banner=Spr or banner=Lp. However, bannerGen.php would need to be modified to include this additional parameter. The best solution to this would have bannerGen.php mirror shieldgen.php and simply intake the root ($r). Then the required parameters can be pulled from the database and stored in the $row array as in shieldgen.php. This would require the following modifications:
- change tm_banner_generate function inputs in bannerGen.php
- add code to assign the $row array in bannerGen.php (copy-paste from shieldgen.php?)
- change $banner and $system to $row['banner'] and $row['systemName'] respectively
- change input to tm_banner_generate in clinched.php
- change input to tm_banner_generate in showroute.php
This would also be helpful in advancing #602 and #632. Something for me to look into further in the coming days/weeks.