Skip to content

Bad output on patch archive extraction #139

@heinermann

Description

@heinermann

When extracting storm.dll from a patch archive using mpqcli, it appears to be corrupted with extra bytes before the header. MPQEditor extracts the file without the extra bytes.

In a powershell,

curl -L -o patch.exe http://ftp.blizzard.com/pub/broodwar/patches/PC/BW-1161.exe
curl -L -o mpqcli.exe "https://github.com/TheGrayDot/mpqcli/releases/download/v0.9.6/mpqcli-windows-amd64.exe"
.\mpqcli.exe extract -f storm.dll -o . patch.exe
Source Filesize
mpqcli 409,624 bytes
MPQEditor 409,600 bytes

Extra bytes before the magic MZ (PE header).
18 00 04 01 00 00 00 00 00 00 00 00 00 40 06 00 F2 7C 83 AE AD 72 C9 01

Do you know if this is actually part of the file that MPQEditor strips out magically or if it's a bug in mpqcli? The 4th dword seems to be the filesize.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions