From a481b07db49db9fb13d497f8ee6c7ff83db84fae Mon Sep 17 00:00:00 2001 From: James Cross Date: Wed, 28 Jan 2026 20:51:22 +0000 Subject: [PATCH] fix(services): handle null CreatedBy for legacy services Legacy services created before CreatedBy was required have null values. Fall back to current user or 'system' to prevent validation errors. --- src/controllers/serviceController.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/controllers/serviceController.ts b/src/controllers/serviceController.ts index 91b8463..1601d04 100644 --- a/src/controllers/serviceController.ts +++ b/src/controllers/serviceController.ts @@ -227,9 +227,11 @@ export const updateService = asyncHandler(async (req: Request, res: Response) => } // Prepare update data + // Use existing CreatedBy if available, otherwise fall back to current user + // (handles legacy services created before CreatedBy was required) const updateData = { ...validation.data, - CreatedBy: existingService.CreatedBy, + CreatedBy: existingService.CreatedBy || req.user?._id || req.body?.CreatedBy || 'system', DocumentModifiedDate: new Date() };