Skip to content

WinConsole's tty check is inaccurate #62

@retep998

Description

@retep998

When using WinConsole::new() it takes an arbitrary writer, but then it doesn't check whether that writer is a console, instead it just gets a handle to the current console buffer, whatever it is, and applies attributes to that, assuming that is also the writer.

This leads to silly situations where if someone passes a writer to WinConsole::new() that isn't the windows console but a pipe or any other sort of writer, or even a console framebuffer that isn't the active one, term will still set the attributes on the console frame buffer that was active at the time WinConsole::new() was called.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions