From e478b2e46cfde8441b78adf0e9ac93006cb7ea4b Mon Sep 17 00:00:00 2001 From: Millitza Kroonenberg Date: Mon, 2 Sep 2019 14:29:05 +0200 Subject: [PATCH 1/5] Pass noAckStream variable for create function --- src/provider.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/provider.js b/src/provider.js index 4e78508..648a6e2 100644 --- a/src/provider.js +++ b/src/provider.js @@ -176,7 +176,7 @@ class Provider extends Duplex { ); this._create = exec( - partial(request, [this._subjects.create[0]]), { timeout } + partial(request, [this._subjects.create[0]]), { noAckStream, timeout } ); // Allows piping to provider without acknowledgement, i.e. fire and forget From 713816fc8e00a48ee17bd52435569c593a0c7818 Mon Sep 17 00:00:00 2001 From: Millitza Kroonenberg Date: Thu, 26 Nov 2020 11:03:33 +0100 Subject: [PATCH 2/5] bump version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 95bb730..87cbb5c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "pubsub-store", - "version": "0.8.1", + "version": "0.8.2", "description": "Pub/Sub Store", "main": "src/index.js", "scripts": { From 5a31e088b42a1a8a42e5da7d3080f5cf4e3ef456 Mon Sep 17 00:00:00 2001 From: Millitza Kroonenberg Date: Thu, 26 Nov 2020 11:05:39 +0100 Subject: [PATCH 3/5] update readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4f018c6..b606328 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,7 @@ details. #### Methods -`constructor({ schema, transport, getSubjects, options: { batchSize, highWaterMark, noAckStreams, timeout }}` +`constructor({ schema, transport, getSubjects, options: { batchSize, highWaterMark, noAckStream, timeout }}` * `schema` @@ -114,7 +114,7 @@ details. When set, the stream will push messages in chunks of that size. - * `noAckStreams` + * `noAckStream` When `true`, allows piping to provider without acknowledgement, i.e. fire and forget. From c5f1755b89d77ba883043249f4a055671ab5894f Mon Sep 17 00:00:00 2001 From: Millitza Kroonenberg Date: Thu, 26 Nov 2020 11:20:26 +0100 Subject: [PATCH 4/5] simplified no ack check in exec function --- src/provider.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/provider.js b/src/provider.js index 648a6e2..7b1d2b8 100644 --- a/src/provider.js +++ b/src/provider.js @@ -76,14 +76,12 @@ const exec = curry((request, { noAckStream, timeout }, query) => new Promise( // reject query on timeout // NB: timeout is set in Promise context only when noAckStream // is false and is cancelled in request callback - tap(partial(clearTimeout, [ !noAckStream - ? setTimeout( - partial(reject, [ - new ProviderError(`query timeout after ${timeout}ms`, query) - ]), - timeout - ) - : null + tap(partial(clearTimeout, [ setTimeout( + partial(reject, [ + new ProviderError(`query timeout after ${timeout}ms`, query) + ]), + timeout + ) ])), JSON.parse, From 334f439b96d252f9ef704dec9cae2b8e8ceaa028 Mon Sep 17 00:00:00 2001 From: Millitza Kroonenberg Date: Mon, 30 Nov 2020 09:15:33 +0100 Subject: [PATCH 5/5] undo no ack stream in create --- src/provider.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/provider.js b/src/provider.js index 7b1d2b8..d43010a 100644 --- a/src/provider.js +++ b/src/provider.js @@ -174,7 +174,7 @@ class Provider extends Duplex { ); this._create = exec( - partial(request, [this._subjects.create[0]]), { noAckStream, timeout } + partial(request, [this._subjects.create[0]]), { timeout } ); // Allows piping to provider without acknowledgement, i.e. fire and forget