Oauth throws an exception, slamming the response code and body together

[GhostToast]

Oauth is stringifying the output if the reseponse code is 400 or greater. However, having this information returned in a normal way, and checked further downstream, would be more useful. In our application, we expect JSON to be returned, but instead are getting this text.

https://github.com/Semantics3/semantics3-php/blob/master/lib/oauth-php/library/OAuthRequester.php#L115-L118

[GhostToast]

404 is the response code for products that aren't in the database, so this is a rather common code we would expect to receive back.

[fcha]

We are experiencing the same issue. It looks like back in May UPCs that aren't recognized by Semantics3 are throwing an error with the following message "Request failed with code 400: {"message":"The given upc is invalid","code":1026}". Unfortunately by the time we get the results it is null and we can't do anything about it.

[fcha]

It looks like that the semantics3 php library is outputting the message in console rather than throwing an error.

https://github.com/Semantics3/semantics3-php/blob/master/lib/Semantics3/ApiConnector.php#L52-L57

However the python library does throw an error
https://github.com/Semantics3/semantics3-python/blob/master/semantics3/semantics3.py#L117-L123

For the time being the best way to handle this until it is fixed would be to intercept the output buffer using ob_start() and ob_get_contents() and than parsing the contents of the result using the following code. The contents of $errorMessage would be JSON.

    //remove any trailing white spaces and/or line breaks
    $message = trim($message);

    //find the message and code string position
    $errorPosition = strpos($message, '{');

    //retrieve error message
    $errorMessage = substr($message, $errorPosition);