Fix menu bar on generic scattering calculator tool (Trac #354)

[butlerpd]

The generic scattering calculator tool brings up a window with its own menu bar -- however none of those icons work. This may be a problem with Wx 3.0?

Migrated from http://trac.sasview.org/ticket/354

{
    "status": "closed",
    "changetime": "2015-03-01T17:46:13",
    "_ts": "2015-03-01 17:46:13.032185+00:00",
    "description": "The generic scattering calculator tool brings up a window with its own menu bar -- however none of those icons work.  This may be a problem with Wx 3.0?",
    "reporter": "butler",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2015-02-18T21:51:52",
    "component": "SasView",
    "summary": "Fix menu bar on generic scattering calculator tool",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 3.1.0",
    "owner": "",
    "type": "defect"
}

[butlerpd]

Trac update at 2015/03/01 17:46:13:

• butler commented:

Somebody had changed to using wx.toolbar for wx3.0 instead of the old createtoolbar (which uses toolbar but takes care of all the frame management). Because the window is rather complicated the frame management was not being done properly and caused problem on windows 8.1 machines at least (not sure about others). While it could be fixed by rewriting a lot of structure, I completely removed the toolbar since

a) no other tool panels use it (i.e. not consistant in look and feel)
b) the toolbar was completely gratuitious, duplicating very obvious functionality except for the help

I added a help button just like I added to every other tool panel so that all panels now are a click away from panel help and in exactly the same way.

• butler changed resolution from "" to "fixed"
• butler changed status from "new" to "closed"