make compiler issues on os x Yosemite.

[iezed]

Hi, I have this error.

/Users/fabrizio/github/games/SFTtech/openage/libopenage/util/fslike/directory.cpp:213:16: error: use of undeclared
      identifier 'CLOCK_REALTIME'
        clock_gettime(CLOCK_REALTIME, ts);
                      ^
1 error generated.

[TheJJ]

@Birch-san it works for you, right? Any idea why it might bug for @iezed?

[zuntrax]

This happens in an Apple specific code block. I'd expect this to be included from time.h or sys/time.h in your include directory. This files should be present, otherwise there would have been another error. Can you check if CLOCK_REALTIME is defined in these files (and if not, in any other header in the global include directory)?

[Birch-san]

It worked for me; I use macOS Sierra. But apparently anything older than that will have trouble:

https://stackoverflow.com/questions/5167269/clock-gettime-alternative-in-mac-os-x

[iezed]

I found this tips : https://gist.github.com/jbenet/1087739, Maybe it may be useful.

[Birch-san]

Am I right in assuming that #ifdef __MACH__ is basically the same as #ifdef __APPLE__? So it probably treats macOS Sierra and older macOS the same way.

If we use it verbatim: it will mean that we don't use clock_gettime() on macOS Sierra (even though it's available). maybe that's not a problem (I mean we're already in the middle of a compromise because we don't have utimensat), but still: I would prefer to keep the macOS Sierra build running the way it currently does.

I wonder if there's a more specific check that we can do than #ifdef __MACH__ .
I am not sure how to verify those constraints: macOS > 10.12 && XCode >= 8

[iezed]

I'm try this :

#ifdef __MACH__
#include <mach/clock.h>
#include <mach/mach.h>
#endif

#ifdef __APPLE__
	struct timespec ts;
	//clock_gettime(CLOCK_REALTIME, ts);
	
	clock_serv_t cclock;
	mach_timespec_t mts;
	host_get_clock_service(mach_host_self(), CALENDAR_CLOCK, &cclock);
	clock_get_time(cclock, &mts);
	mach_port_deallocate(mach_task_self(), cclock);
	ts.tv_sec = mts.tv_sec;
	ts.tv_nsec = mts.tv_nsec;
	
	struct timeval tv[2];
	tv[0].tv_sec = ts.tv_sec;
	tv[0].tv_usec = ts.tv_nsec*1000;
	tv[1].tv_sec = ts.tv_sec;
	tv[1].tv_usec = ts.tv_nsec*1000;
	int result = utimes(path.c_str(), tv);
#else
	int result = utimensat(AT_FDCWD, path.c_str(), nullptr, 0) == 0;
#endif 

and worked, but when I runned I have blank screen.

[iezed]

http://stackoverflow.com/questions/2166483/which-macro-to-wrap-mac-os-x-specific-code-in-c-c

[VelorumS]

and worked, but when I runned I have blank screen.

That may be another issue. We need someone with Mac to debug the input/dispatcher thing (#756 (comment)). It's not really reproducible.

[Birch-san]

I confirm that black screen is exactly what you should expect on master.

Like ChipmunkV says, you will need his magic commit if you want it to work:
VelorumS@d577f56

@ChipmunkV, I know you've said that the commit was removed because it was unexplainable. But where did you get the idea to do that? Did you read something somewhere?

[iezed]

Hi, I worked with copy download from gui-gl-context-fix-3 and I wrote in to the directory.cpp this :

https://gist.github.com/iezed/92c423da1ffe822e18d1da3284a6819a

I can build and when I ran, I don't have a black screen, I can see something.

[Birch-san]

@iezed, I want to see what preprocessor macros are available in your environment.
Please show me the output you get on your computer when running:

clang -x c++ -dM -E - < /dev/null | egrep -i '(apple|clang|mac)'

For reference, this is what I get (Mac OS 10.12 Sierra, XCode 8.3.2):

#define __APPLE_CC__ 6000
#define __APPLE__ 1
#define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 101200
#define __MACH__ 1
#define __VERSION__ "4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)"
#define __apple_build_version__ 8020042
#define __clang__ 1
#define __clang_major__ 8
#define __clang_minor__ 1
#define __clang_patchlevel__ 0
#define __clang_version__ "8.1.0 (clang-802.0.42)"

For reference I have heard that XCode 7 resembles this:
https://stackoverflow.com/questions/32985758/what-is-the-llvm-version-bundled-with-xcode-7

[iezed]

#define __APPLE_CC__ 6000
#define __APPLE__ 1
#define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 101000
#define __MACH__ 1
#define __VERSION__ "4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)"
#define __apple_build_version__ 7000181
#define __clang__ 1
#define __clang_major__ 7
#define __clang_minor__ 0
#define __clang_patchlevel__ 2
#define __clang_version__ "7.0.2 (clang-700.1.81)"