From e7ab7b9f22e4f6e2798ce7fb69f6030a1f45685e Mon Sep 17 00:00:00 2001 From: Brandon Tweed Date: Tue, 22 Apr 2025 14:53:03 -0500 Subject: [PATCH 1/3] Update rbac.v1.integration.test.ts Add `limit` parameter to `getPrincipalAccessParams` object. --- packages/rbac/tests/integration/rbac.v1.integration.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/rbac/tests/integration/rbac.v1.integration.test.ts b/packages/rbac/tests/integration/rbac.v1.integration.test.ts index 24f3d3276..4147bec88 100644 --- a/packages/rbac/tests/integration/rbac.v1.integration.test.ts +++ b/packages/rbac/tests/integration/rbac.v1.integration.test.ts @@ -39,6 +39,7 @@ describe('RBAC API (v1)', () => { const getPrincipalAccessParams: GetPrincipalAccessParams = { application: 'jeff', + limit: 567 }; const getPrincipalAccessResp = await client.getPrincipalAccess(getPrincipalAccessParams); expect(getPrincipalAccessResp.status).toEqual(200); From 8afeb8b5c2d2a5c8b43cdc789e23f44eec22c52a Mon Sep 17 00:00:00 2001 From: Brandon Tweed Date: Tue, 22 Apr 2025 15:02:41 -0500 Subject: [PATCH 2/3] Add test for missing application value --- packages/rbac/tests/integration/rbac.v1.integration.test.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/rbac/tests/integration/rbac.v1.integration.test.ts b/packages/rbac/tests/integration/rbac.v1.integration.test.ts index 4147bec88..c523a9379 100644 --- a/packages/rbac/tests/integration/rbac.v1.integration.test.ts +++ b/packages/rbac/tests/integration/rbac.v1.integration.test.ts @@ -43,6 +43,10 @@ describe('RBAC API (v1)', () => { }; const getPrincipalAccessResp = await client.getPrincipalAccess(getPrincipalAccessParams); expect(getPrincipalAccessResp.status).toEqual(200); + + // application value is required per RBAC spec + const getPrincipalAccessRespError = await client.getPrincipalAccess(null); + expect(getPrincipallAccessRespError.status).toEqual(400); }); test('groups crud operations', async () => { From 0630d715f0c391785daa93e67d61f3e9553e55fb Mon Sep 17 00:00:00 2001 From: Darth Tweed Date: Tue, 22 Apr 2025 15:08:26 -0500 Subject: [PATCH 3/3] Typo/formatting --- packages/rbac/tests/integration/rbac.v1.integration.test.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/rbac/tests/integration/rbac.v1.integration.test.ts b/packages/rbac/tests/integration/rbac.v1.integration.test.ts index c523a9379..f43f327cf 100644 --- a/packages/rbac/tests/integration/rbac.v1.integration.test.ts +++ b/packages/rbac/tests/integration/rbac.v1.integration.test.ts @@ -39,14 +39,13 @@ describe('RBAC API (v1)', () => { const getPrincipalAccessParams: GetPrincipalAccessParams = { application: 'jeff', - limit: 567 + limit: 567, }; const getPrincipalAccessResp = await client.getPrincipalAccess(getPrincipalAccessParams); expect(getPrincipalAccessResp.status).toEqual(200); - // application value is required per RBAC spec const getPrincipalAccessRespError = await client.getPrincipalAccess(null); - expect(getPrincipallAccessRespError.status).toEqual(400); + expect(getPrincipalAccessRespError.status).toEqual(400); }); test('groups crud operations', async () => {