Rbac client mangles request query parameters

[Hyperkid123]

Example: https://stackblitz.com/edit/vitejs-vite-mygi8omd?file=src%2Fmain.ts

Fillowing code creates a request with invalid query parameters.

import { APIFactory } from '@redhat-cloud-services/javascript-clients-shared';
import getPrincipalAccess from '@redhat-cloud-services/rbac-client/GetPrincipalAccess';

const rbacApi = APIFactory("/", {
  getPrincipalAccess
})

rbacApi.getPrincipalAccess({
  application: 'foo',
  limit: 123
})

If you check the network tab these params are created:

?application.application=foo&application.limit=123

But correct parameters should be:

?application=foo&limit=123

[catastrophe-brandon]

It looks like this type of client consumption is different from the way test automation covers the client. The test roughly looks like this:

import { RbacClient } from '../../api';
   ...
const client = RbacClient(BASE_PATH);
const getPrincipalAccessParams: GetPrincipalAccessParams = {
      application: 'jeff',
      limit: 567,
    };
const getPrincipalAccessResp = await client.getPrincipalAccess(getPrincipalAccessParams);
expect(getPrincipalAccessResp.status).toEqual(200);

You'll notice that we import the client directly instead of using the APIFactory. If the usage of APIFactory is a supported use case, I believe we need more automated test coverage.

[Hyperkid123]

Yeah usage of the API factory is in fact preferred as you can optimize the size of the JS in your bundle. Most of UI modules use about 10 of each client functions. However, the client itself can have hundreds, which bloats the size of the JS assets.