AttributeError: module 'redssh.clients' has no attribute 'default_client'

[netsamir]

Hi,

I have just downloaded RedExpect which raises an exception from RedSSH.

[nav] In [11]: import redssh

[ins] In [12]:  rs = redssh.RedSSH()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-12-5b77a74c0c4c> in <module>
----> 1 rs = redssh.RedSSH()

/home/e83/projects/swsh/local/lib64/python3.6/site-packages/redssh/redssh.py in __init__(self, encoding, terminal, known_hosts, ssh_host_key_verification, ssh_keepalive_interval, set_flags, method_preferences, callbacks, auto_terminate_tunnels, tcp_nodelay)
     38         ssh_keepalive_interval=0.0,set_flags={},method_preferences={},callbacks={},auto_terminate_tunnels=False,tcp_nodelay=False):
     39         self.debug = False
---> 40         self.client = self.pick_client()(encoding=encoding,terminal=terminal,known_hosts=known_hosts,ssh_host_key_verification=ssh_host_key_verification,
     41             ssh_keepalive_interval=ssh_keepalive_interval,set_flags=set_flags,method_preferences=method_preferences,callbacks=callbacks,
     42             auto_terminate_tunnels=auto_terminate_tunnels,tcp_nodelay=tcp_nodelay)

/home/e83/projects/swsh/local/lib64/python3.6/site-packages/redssh/redssh.py in pick_client(self, ssh_client, custom_ssh_clients)
     44
     45     def pick_client(self,ssh_client=None,custom_ssh_clients={}):
---> 46         default_client = clients.default_client
     47         if ssh_client==None:
     48             ssh_client = default_client

AttributeError: module 'redssh.clients' has no attribute 'default_client'

Thanks

[Red-M]

Did either of the client libraries get installed?
If its not able to import them, no default client is set.

RedSSH/redssh/clients/__init__.py

Lines 33 to 45 in afafd6b

	try:
	import redssh.clients.libssh as libssh
	enabled_clients[SSHClient.libssh] = libssh.LibSSH
	default_client = SSHClient.libssh
	except:
	pass
	try:
	import redssh.clients.libssh2 as libssh2
	enabled_clients[SSHClient.libssh2] = libssh2.LibSSH2
	default_client = SSHClient.libssh2
	except:
	pass

Please make sure that redlibssh or redlibssh2 is properly installed.

However, the library should raise an error to indicate that this has happened.

[netsamir]

I think I have found the problem my changing the code as follow:

try:
   from . import libssh as libssh
   enabled_clients[SSHClient.libssh] = libssh.LibSSH
   default_client = SSHClient.libssh
except:
   pass

try:
   from . import libssh2 as libssh2
   enabled_clients[SSHClient.libssh2] = libssh2.LibSSH2
   default_client = SSHClient.libssh2
except:
   pass

And here is the call:

[ins] In [1]: import redssh

[ins] In [2]: rs = redssh.RedSSH()

[ins] In [3]: rs.client
Out[3]: <redssh.clients.libssh2.redsshlibssh2.LibSSH2 at 0x7fb2c55a21d0>

[ins] In [4]:

[Red-M]

Could you try import redssh.clients.libssh2 as libssh2 as the absolute imports should be working.
I'm curious if this is something that ipython does.

[netsamir]

Yes, that's working I have tested before too:

[ins] In [14]: import redssh.clients.libssh2 as libssh2

[ins] In [15]:

But why do you do an absolute import instead of relative import ?

[Red-M]

Its clear where the import is going to import from. Explicit over implicit.

IIRC, there was issues with older/newer versions of python that did not like the relative import.

[netsamir]

Probably a combination of relative/absolute import could be good:

try:
   import redssh.clients.libssh as libssh
   enabled_clients[SSHClient.libssh] = libssh.LibSSH
   default_client = SSHClient.libssh
except:
   try:
      from . import libssh as libssh
      enabled_clients[SSHClient.libssh] = libssh.LibSSH
      default_client = SSHClient.libssh
   except:
      pass

try:
   import redssh.clients.libssh2 as libssh2
   enabled_clients[SSHClient.libssh2] = libssh2.LibSSH2
   default_client = SSHClient.libssh2
except:
   try:
      from . import libssh2 as libssh2
      enabled_clients[SSHClient.libssh2] = libssh2.LibSSH2
      default_client = SSHClient.libssh2
    except:
      pass

[Red-M]

Something seems strange about your environment as I can't reproduce this on python 3.5 or python 3.7.

[Red-M]

I tested this today with python 3.9 and ipython, I couldn't reproduce this bug.

Can you please make sure you're using an up to date version of python and ipython?

[netsamir]

Hi,

We are using python 3.6. I am not the administrator of the server (RedHat) on which I am working. I run inside a virtual environment

Looking in links: /home/netsamir/packages
Requirement already satisfied: ipython in ./local/lib/python3.6/site-packages (7.16.1)
Processing /home/netsamir/packages/ipython-7.16.3-py3-none-any.whl
Requirement already satisfied: backcall in ./local/lib/python3.6/site-packages (from ipython) (0.2.0)
Requirement already satisfied: traitlets>=4.2 in ./local/lib/python3.6/site-packages (from ipython) (4.3.3)
Requirement already satisfied: jedi<=0.17.2,>=0.10 in ./local/lib/python3.6/site-packages (from ipython) (0.17.2)
Requirement already satisfied: decorator in ./local/lib/python3.6/site-packages (from ipython) (4.4.2)
Requirement already satisfied: setuptools>=18.5 in ./local/lib/python3.6/site-packages (from ipython) (39.2.0)
Requirement already satisfied: pexpect in ./local/lib/python3.6/site-packages (from ipython) (4.8.0)
Requirement already satisfied: pickleshare in ./local/lib/python3.6/site-packages (from ipython) (0.7.5)
Requirement already satisfied: pygments in ./local/lib/python3.6/site-packages (from ipython) (2.13.0)
Requirement already satisfied: prompt-toolkit!=3.0.0,!=3.0.1,<3.1.0,>=2.0.0 in ./local/lib/python3.6/site-packages (from ipython) (3.0.18)
Requirement already satisfied: parso<0.8.0,>=0.7.0 in ./local/lib/python3.6/site-packages (from jedi<=0.17.2,>=0.10->ipython) (0.7.1)
Requirement already satisfied: wcwidth in ./local/lib/python3.6/site-packages (from prompt-toolkit!=3.0.0,!=3.0.1,<3.1.0,>=2.0.0->ipython) (0.2.5)
Requirement already satisfied: six in ./local/lib/python3.6/site-packages (from traitlets>=4.2->ipython) (1.16.0)
Requirement already satisfied: ipython-genutils in ./local/lib/python3.6/site-packages (from traitlets>=4.2->ipython) (0.2.0)
Requirement already satisfied: ptyprocess>=0.5 in ./local/lib/python3.6/site-packages (from pexpect->ipython) (0.7.0)
Installing collected packages: ipython
  Attempting uninstall: ipython
    Found existing installation: ipython 7.16.1
    Uninstalling ipython-7.16.1:
      Successfully uninstalled ipython-7.16.1
Successfully installed ipython-7.16.3


$ pip install redexpect -U
Looking in links: /home/netsamir/packages
Requirement already satisfied: redexpect in ./local/lib/python3.6/site-packages (2.0.3.post3)
Requirement already satisfied: redssh>=2* in ./local/lib/python3.6/site-packages (from redexpect) (3.0.1)
Requirement already satisfied: redlibssh2>=2.1.1-1 in ./local/lib/python3.6/site-packages (from redssh>=2*->redexpect) (2.1.5.post1)
Requirement already satisfied: redlibssh>=2.0.3 in ./local/lib/python3.6/site-packages (from redssh>=2*->redexpect) (2.0.9)


$ cat ./local/lib/python3.6/site-packages/redssh/clients/__init__.py

from redssh.enums import SSHClient

VERSION = u'1.0.0'

enabled_clients = {}


try:
   import redssh.clients.libssh as libssh
   enabled_clients[SSHClient.libssh] = libssh.LibSSH
   default_client = SSHClient.libssh
except:
      pass

try:
   import redssh.clients.libssh2 as libssh2
   enabled_clients[SSHClient.libssh2] = libssh2.LibSSH2
   default_client = SSHClient.libssh2
except:
      pass



$ ipython
Python 3.6.8 (default, Aug 13 2020, 07:46:32)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.16.3 -- An enhanced Interactive Python. Type '?' for help.
[TerminalIPythonApp] WARNING | File not found: '%autoreload 2'

[ins] In [1]: import redexpect

[ins] In [2]: import redssh

[ins] In [3]: rs = redssh.RedSSH()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-3-5b77a74c0c4c> in <module>
----> 1 rs = redssh.RedSSH()

/home/netsamir/projects/swsh/local/lib64/python3.6/site-packages/redssh/redssh.py in __init__(self, encoding, terminal, known_hosts, ssh_host_key_verification, ssh_keepalive_interval, set_flags, method_preferences, callbacks, auto_terminate_tunnels, tcp_nodelay)
     38         ssh_keepalive_interval=0.0,set_flags={},method_preferences={},callbacks={},auto_terminate_tunnels=False,tcp_nodelay=False):
     39         self.debug = False
---> 40         self.client = self.pick_client()(encoding=encoding,terminal=terminal,known_hosts=known_hosts,ssh_host_key_verification=ssh_host_key_verification,
     41             ssh_keepalive_interval=ssh_keepalive_interval,set_flags=set_flags,method_preferences=method_preferences,callbacks=callbacks,
     42             auto_terminate_tunnels=auto_terminate_tunnels,tcp_nodelay=tcp_nodelay)

/home/netsamir/projects/swsh/local/lib64/python3.6/site-packages/redssh/redssh.py in pick_client(self, ssh_client, custom_ssh_clients)
     44
     45     def pick_client(self,ssh_client=None,custom_ssh_clients={}):
---> 46         default_client = clients.default_client
     47         if ssh_client==None:
     48             ssh_client = default_client

AttributeError: module 'redssh.clients' has no attribute 'default_client'