LaTeX and other builds of the manual fail

[rptb1]

Attempting to build a LaTeX version of the MPS manual fails in the MPS Sphinx extension:

Exception occurred:
  File "/home/rb/git/mps/manual/source/extensions/mps/__init__.py", line 117, in visit_admonition_node
    self.visit_admonition(node, name=name)
TypeError: LaTeXTranslator.visit_admonition() got an unexpected keyword argument 'name'

[rptb1]

Prevention:

make -C manual indicates various other possible build output formats:

Please use `make <target>' where <target> is one of
  html       to make standalone HTML files
  dirhtml    to make HTML files named index.html in directories
  singlehtml to make a single large HTML file
  pickle     to make pickle files
  json       to make JSON files
  htmlhelp   to make HTML files and a HTML help project
  qthelp     to make HTML files and a qthelp project
  devhelp    to make HTML files and a Devhelp project
  epub       to make an epub
  latex      to make LaTeX files, you can set PAPER=a4 or PAPER=letter
  latexpdf   to make LaTeX files and run them through pdflatex
  text       to make text files
  man        to make manual pages
  texinfo    to make Texinfo files
  info       to make Texinfo files and run them through makeinfo
  gettext    to make PO message catalogs
  changes    to make an overview of all changed/added/deprecated items
  linkcheck  to check all external links for integrity
  doctest    to run all doctests embedded in the documentation (if enabled)
  tools      to install a local copy of the Python tools using virtualenv

This is the default list generated when creating a Sphinx project, and we have not updated it. It also came from a much older version of Sphinx than the current one.

We should:

• check it against the list from the Sphinx version we use (and automate such a check?)
• cut it down to formats we actually support (commenting out others)
• add a CI target to make all the formats we support
• build all those formats in a CI task

We should pay special attention to the "linkcheck" target.

[rptb1]

Here's the output of make -C manual linkcheck at 142999b run today.

output.txt

[rptb1]

It may be wise to resolve #166 and #121 then come back to this, to avoid rework.

[rptb1]

It may be wise to resolve #166 and #121 then come back to this, to avoid rework.

I have checked and the LaTeX build is not fixed by upgrading to Sphinx 6.1.3. Still a good idea to resolve this after those other issues though, so that the fix is up to date.