Refresh inserts wrong service IP

[synologic]

Hi,

Is there any particular reason for which at line 200 you are doing:

table.insert(addresses, node.Node.Address .. ":" .. node.Service.Port)

instead of

table.insert(addresses, node.Service.Address .. ":" .. node.Service.Port)

That will effectively add the Consul node address instead of the actual Service registration address ?

Thanks

[roman-vynar]

@synologic Sorry, missed your question for some reason.

Yes, there is a reason for that.
balancer.set_current_peer() requires an IP address and hostnames do not make sense.
See https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#set_current_peer

node.Node.Address stands for IP address.
node.Service.Address stands for hostname (unless your Consul registrations are not doing that and still setting to an IP).

In the latest commit I have added 3rd arg to balancer.set_current_peer() to support SNI. This is not important for Go services on the backend but Java ones with the latest Dropwizard and default SNI enabled will not work otherwise.

[roman-vynar]

In any case our setup is simple 1 node == 1 IP. In case you are doing something more specific, multiple IP addresses etc. it's all up to you. But we can change something here to make it in and useful for others.