chore: Address co-pilot review feedback

Author: allenporter

tests/fixtures/local_async_fixtures.py

@@ -1,10 +1,14 @@
 import asyncio
+import logging
+import warnings
 from collections.abc import Awaitable, Callable, Generator
 from typing import Any
 from unittest.mock import Mock, patch
 
 import pytest
 
+_LOGGER = logging.getLogger(__name__)
+
 AsyncLocalRequestHandler = Callable[[bytes], Awaitable[bytes | None]]
 
 
@@ -16,10 +20,11 @@ def received_requests_fixture() -> asyncio.Queue[bytes]:
 
 @pytest.fixture(name="local_response_queue")
 def response_queue_fixture() -> Generator[asyncio.Queue[bytes], None, None]:
-    """Fixture that provides access to the received requests."""
+    """Fixture that provides a queue of responses to be sent to the client."""
     response_queue: asyncio.Queue[bytes] = asyncio.Queue()
     yield response_queue
-    # assert response_queue.empty(), "Not all fake responses were consumed"
+    if not response_queue.empty():
+        warnings.warn("Some enqueued local device responses were not consumed during the test")
 
 
 @pytest.fixture(name="local_async_request_handler")

tests/fixtures/pahomqtt_fixtures.py

@@ -73,7 +73,7 @@ def received_requests_fixture() -> Queue[bytes]:
 
 @pytest.fixture(name="mqtt_response_queue")
 def response_queue_fixture() -> Generator[Queue[bytes], None, None]:
-    """Fixture that provides access to the received requests."""
+    """Fixture that provides a queue for enqueueing responses to be sent to the client under test."""
     response_queue: Queue[bytes] = Queue()
     yield response_queue
     assert response_queue.empty(), "Not all fake responses were consumed"

tests/test_local_api_v1.py

@@ -3,11 +3,11 @@
 import asyncio
 import json
 import logging
-from asyncio import Protocol
 from collections.abc import AsyncGenerator, Callable, Generator
 from queue import Queue
 from typing import Any
 from unittest.mock import Mock, patch
+import warnings
 
 import pytest
 import syrupy
@@ -42,10 +42,11 @@ def received_requests_fixture() -> Queue[bytes]:
 
 @pytest.fixture(name="local_response_queue")
 def response_queue_fixture() -> Generator[Queue[bytes], None, None]:
-    """Fixture that provides access to the received requests."""
+    """Fixture that provides a queue for enqueueing responses to be sent back to the client under test."""
     response_queue: Queue[bytes] = Queue()
     yield response_queue
-    assert response_queue.empty(), "Not all fake responses were consumed"
+    if not response_queue.empty():
+        warnings.warn("Not all fake responses were consumed")
 
 
 @pytest.fixture(name="local_request_handler")
@@ -72,7 +73,7 @@ def create_local_connection_fixture(
 ) -> Generator[None, None, None]:
     """Fixture that overrides the transport creation to wire it up to the mock socket."""
 
-    async def create_connection(protocol_factory: Callable[[], Protocol], *args) -> tuple[Any, Any]:
+    async def create_connection(protocol_factory: Callable[[], asyncio.Protocol], *args) -> tuple[Any, Any]:
         protocol = protocol_factory()
 
         def handle_write(data: bytes) -> None: