chore: clean up tests from previous pr (#687)

Author: Lash-L

tests/devices/test_local_channel.py

@@ -2,6 +2,7 @@
 
 import asyncio
 import json
+import logging
 from collections.abc import Generator
 from unittest.mock import AsyncMock, Mock, patch
 
@@ -149,10 +150,11 @@ async def test_successful_command_response(local_channel: LocalChannel, mock_loo
 
 async def test_message_decode_error(local_channel: LocalChannel, caplog: pytest.LogCaptureFixture) -> None:
     """Test handling of message decode errors."""
-    local_channel._data_received(b"invalid_payload")
-    await asyncio.sleep(0.01)  # yield
+    with caplog.at_level(logging.WARNING):
+        local_channel._data_received(b"invalid_payload")
+        await asyncio.sleep(0.01)  # yield
 
-    warning_records = [record for record in caplog.records if record.levelname == "WARNING"]
+    warning_records = caplog.records
     assert len(warning_records) == 1
     assert "Failed to decode message" in warning_records[0].message
 

tests/devices/test_local_decoder_padding.py

@@ -155,10 +155,11 @@ async def test_message_decode_error(
     callback = Mock()
     unsub = await mqtt_channel.subscribe(callback)
 
-    mqtt_message_handler(b"invalid_payload")
-    await asyncio.sleep(0.01)  # yield
+    with caplog.at_level(logging.WARNING):
+        mqtt_message_handler(b"invalid_payload")
+        await asyncio.sleep(0.01)  # yield
 
-    warning_records = [record for record in caplog.records if record.levelname == "WARNING"]
+    warning_records = caplog.records
     assert len(warning_records) == 1
     assert "Failed to decode message" in warning_records[0].message
     unsub()

tests/devices/test_mqtt_channel.py

@@ -0,0 +1,55 @@
+import pytest
+
+from roborock.protocol import create_local_decoder, create_local_encoder
+from roborock.roborock_message import RoborockMessage, RoborockMessageProtocol
+
+TEST_LOCAL_KEY = "local_key"
+
+
+@pytest.mark.parametrize(
+    ("garbage"),
+    [
+        b"",
+        b"\x00\x00\x05\xa1",
+        b"\x00\x00\x05\xa1\xff\xff",
+    ],
+)
+def test_decoder_clean_message(garbage: bytes):
+    encoder = create_local_encoder(TEST_LOCAL_KEY)
+    decoder = create_local_decoder(TEST_LOCAL_KEY)
+    msg = RoborockMessage(
+        protocol=RoborockMessageProtocol.RPC_REQUEST,
+        payload=b"test_payload",
+        version=b"1.0",
+        seq=1,
+        random=123,
+    )
+    encoded = encoder(msg)
+    decoded = decoder(garbage + encoded)
+    assert len(decoded) == 1
+    assert decoded[0].payload == b"test_payload"
+
+
+def test_decoder_split_padding_variable():
+    """Test variable padding split across chunks."""
+    encoder = create_local_encoder(TEST_LOCAL_KEY, connect_nonce=123, ack_nonce=456)
+    decoder = create_local_decoder(TEST_LOCAL_KEY, connect_nonce=123, ack_nonce=456)
+
+    msg = RoborockMessage(
+        protocol=RoborockMessageProtocol.RPC_REQUEST,
+        payload=b"test_payload",
+        version=b"L01",
+    )
+    encoded = encoder(msg)
+
+    garbage = b"\x00\x00\x05\xa1\xff\xff"  # 6 bytes
+
+    # Send garbage
+    decoded1 = decoder(garbage)
+    assert len(decoded1) == 0
+
+    # Send message
+    decoded2 = decoder(encoded)
+
+    assert len(decoded2) == 1
+    assert decoded2[0].payload == b"test_payload"