From 5fee4c0fa208122f744cdbd8589f8326b48905ca Mon Sep 17 00:00:00 2001 From: ultimateownsz Date: Fri, 14 Feb 2025 15:02:57 +0100 Subject: [PATCH 1/5] fixes the issue templates I accidently removed the issue templates and these are now back in the correct directory --- .../{.github/ISSUE_TEMPLATE => }/contributor_guide.md | 0 .../{.github/ISSUE_TEMPLATE => }/user_story_based_issue.md | 0 .github/pull_request_template.md => pull_request_template.md | 2 +- 3 files changed, 1 insertion(+), 1 deletion(-) rename .github/ISSUE_TEMPLATE/{.github/ISSUE_TEMPLATE => }/contributor_guide.md (100%) rename .github/ISSUE_TEMPLATE/{.github/ISSUE_TEMPLATE => }/user_story_based_issue.md (100%) rename .github/pull_request_template.md => pull_request_template.md (90%) diff --git a/.github/ISSUE_TEMPLATE/.github/ISSUE_TEMPLATE/contributor_guide.md b/.github/ISSUE_TEMPLATE/contributor_guide.md similarity index 100% rename from .github/ISSUE_TEMPLATE/.github/ISSUE_TEMPLATE/contributor_guide.md rename to .github/ISSUE_TEMPLATE/contributor_guide.md diff --git a/.github/ISSUE_TEMPLATE/.github/ISSUE_TEMPLATE/user_story_based_issue.md b/.github/ISSUE_TEMPLATE/user_story_based_issue.md similarity index 100% rename from .github/ISSUE_TEMPLATE/.github/ISSUE_TEMPLATE/user_story_based_issue.md rename to .github/ISSUE_TEMPLATE/user_story_based_issue.md diff --git a/.github/pull_request_template.md b/pull_request_template.md similarity index 90% rename from .github/pull_request_template.md rename to pull_request_template.md index 3569d66..d5cfa69 100644 --- a/.github/pull_request_template.md +++ b/pull_request_template.md @@ -28,4 +28,4 @@ If you are not sure which template to choose, refer to the descriptions below: --- ## 🔗 Related Links -For more information, check the [Contributing Guidelines](https://github.com/PyCeas/Pyceas/blob/main/CONTRIBUTING.md) for details on submitting pull requests. \ No newline at end of file +For more information, check the [Contributing Guidelines](/CONTRIBUTING.md) for details on submitting pull requests. \ No newline at end of file From fa4d02227906120935c4cfec19292c14b7bb55f3 Mon Sep 17 00:00:00 2001 From: ultimateownsz Date: Fri, 14 Feb 2025 15:46:16 +0100 Subject: [PATCH 2/5] update yml file outside pyceas repo this updates the workflow file to exit the run if there are no python files are found --- .github/workflows/lint_and_test.yml | 30 +++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint_and_test.yml b/.github/workflows/lint_and_test.yml index 6267ea2..49e064c 100644 --- a/.github/workflows/lint_and_test.yml +++ b/.github/workflows/lint_and_test.yml @@ -15,6 +15,13 @@ jobs: - name: Checkout code uses: actions/checkout@v4 + - name: Exit if not Pyceaas repository + run: | + if [ "${{ github.repository }}" != "PyCeas/Pyceas" ]; then + echo "Not running in PyCeas repository. Exiting." + exit 0 + fi + - name: Set up Python uses: actions/setup-python@v5 with: @@ -24,11 +31,30 @@ jobs: run: | python -m pip install --upgrade pip pip install ruff mypy pygame-ce pytmx + + - name: Check for Python files + id: check_files + run: | + git ls-files '*.py' > files.txt + if [ ! -s files.txt ]; then + echo "No Python files found. Skipping lint and type-check." + fi - name: Run ruff + if: success() run: | - ruff check $(git-ls '*.py') + if [ -s files.txt ]; then + ruff check $(cat files.txt) + else + echo "Skipping ruff; no Python files found." + fi - name: Run mypy + if: success() run: | - mypy main.py + if [ -s files.txt ]; then + mypy $(cat files.txt) + else + echo "Skipping mypy; no Python files found." + fi + From 52e19d4c4744eab28cda858a27128115850abfae Mon Sep 17 00:00:00 2001 From: ultimateownsz Date: Fri, 14 Feb 2025 15:46:48 +0100 Subject: [PATCH 3/5] adding helpful info & url ref fix --- Preview_button.png | Bin 0 -> 6549 bytes pull_request_template.md | 5 ++++- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 Preview_button.png diff --git a/Preview_button.png b/Preview_button.png new file mode 100644 index 0000000000000000000000000000000000000000..d4404f804596f999901bac3eda1977e27e1dd333 GIT binary patch literal 6549 zcmb7}RZtvUlZFX8xVuAecO5JP!QDfU5EuyV7Gxk;aCdhS7(7Vufk6k?Ai;tJcMEL3 zs@<)FA@?ZrwT}3-`D&o z5Bp=R(HcBBR{6aOsFvvE01+dm3Z|%&amM?5EUT%88qV`g#nm@~F{YkV{#-Gu^Q=X4 z$JJ`zq7sxlMChH0Ltnm3YGso*+ayX^97>%HKwL-*Wo4=NCAu;_Lnki$e&t>i?B3@* z?@*@9REDQKpb&g26gHekWqkQkTfy!?sjy@#(a<<52ENI!yI)P_;OLMO&&=;|4e->@ z7HP1f=RMz2H>>m{&Jjqy2?=6UjqeoGPOrTuoTX z#)^X#nm2uLIsN9)d)@+lBCa2i>PWM~ue!gn(w9bER$0leXl0&14F?p&EUt14J^J;} z-0Xo!xv_;^sqVcDUX+o$Ri!p}K3IZ2N$b<^i)hDL(z7i#=v8lv8{%GtYe`vvYNTr~ z1^jUpKy~=J*;y3C6Mz_GT$)u3+BTV)Ey4`*KL6#y-9-Pd+Qn<{`sh zXeQ44V=Y7~lnwSXhT^k$vpgvz0)HQquZ34*fx-MBdLW2n>>FqjNiRIU;0E1)5ry<_ z{hhxZKRQV1o!q1)w}dBL+j75taGpp^Pi*rD5(L0afbn0Od!3Xm28ZD;`oPsnY;rj5 z3@xP_HQE`()C5J9PiRHKDJxc?=v?sn`qCKp#%+oxgcCD(%cBh*t8+Wk@xgaR7IM4L zuC^=0El3k+d!)n|BYVU&XjS}9MOwxdnKnGB$Z63O@5KMos>^1gSBV^m#Tdl1WExrW zqr!T^rj1-YW*pO=UDs4_e$iBkI0pc#1z)Qu%jAcxTyO~tg(ocbb%nn__l%~BI<9qe z`aw$Eour3mA5G62*fUj3YI-4Z2Fk?peAK@DMV^PYnvp^A_L9XaQFyXgY_{uw z)o`LOkvghmkQ@Q_HaE_1RUO@85tHLR&c!Gm8I~Zldx9nfpuq&7efm&f|J0rJ^rTcGl9~=c_j2*i^Mx2lkZ=MMd*$Jax>Gz$Q zT6i99f*U+dlDNbDIzlqes!JzHNX#~hz2u-eYMBW${ohxk@*ChHmT@&`(x$_r?Sgis z_=gg#G^=lhq4a5koYXsW%#+Fkk3qPOqe}VlHBMpt-uuQW_)c)Q-}V04(+v4hst|;3 z3AqvEm?G$NQiuAa(Zyi|PWF%s+=hESHR_AHkN4Y>dKNacXldE8rO$58rYd7;#?}sy zZQ`M=dvD5+fym@KF8MGZeMIkBm-HjQCfSHd?P$ortpo?AtcwXlGmra0axO8~gQ|2B z+KDR4FWAp54U^VUEGGObRT@jho!U>RFUz-oc98aOfOjGz>tdO-wZ@JY-d2~73I)L| zwl#&`o&6zv0w|$%Kg}=%N_9I4mP3_c`|oI}r0xrIf&&(F|Im0C(p!rma2y=Rr^W^z zGs9ZVuDPv|InsIf2AFS;QMzZ#9R;6C zcm1GPIOwV+L4s*a@tiVkoz>F627kY5sxpvGD6 zMH0~btry9e^x2`b-GPsC=PKPRKWCG1>+=4y6U!Tu0VNaGj$Ao~W(!5a3F_u24I=qj z)=+X4(5uM*O+VHIdtn&U7yh9HSYdL(Q)&H(c};u5PZSiWrlz{cuPY2yV;EpP43jxx z(Ehnq6mRcsMNBt-K-1&#Tl@3`(WB)QWlSsWB~gbikY8Mfjg7X5PEn0k!2Zdc(Mm_; z1L;kgPN?ra#ZyNf9j|)!mlT3qEx=ed5V={l%HuUo0g$@?_mbn(9M-G{LNhnX*^)8H zn6&be$V)94=4c+-b}?@?8o^!$_1>dzq;%LF?_aK==2zeUg0Ii4t))&ug8FB@_4hyE zGEL|;!DH5@^ZD~v~fC-p&(?$C-fS2`$~0yUEtjnW$I_P-@ z9q42dSq#NQ9c9$q`>ipweCV&O%cP^sqpvvGR&g~FkDb4b_eR81_;v=)AAGEb3A6@^ z(Tz9iJ#Pqe5xXZHAwo+JghJ)ff_9pK@~>J7)j_g%;6<;f{>!?NKg#e1t#05FtH=|N zjehx7l+9wc`wEP8i+*OiSMg!H3l;c@A->BTY;2OwBzwS z&aw@02xjjOQB|uX!EO81gH&DkfrNHVTGrB$-^2KXZQ=IbU950^R-6;ZnSu^?`~WUn zFF6B<5~w7Yt%Y~I=gGJwevToGYqlAm3GRWyj7DC zgZDZ5g@Yr{j@ z`Z|yDD&uKNp^T;v^_+B#ehm#zOiSfKW#R#!Myl$}Ik$m+!o+wK!921~OKQ}(W6kj$ z!$^zIk2p3_F(8pZ=tW?l*<>j<{Zg_9WzbBYO1*X+_5j93a6(H<`NpDP+*Htk68CK< zbFGa{iQEI%VXh?eW@oqH)G0~_#3Sp`*JboqJJ-+-ydXbD&0ULB8V<8sShwB0Im{Ps z_sU*sI7(mY2`@Mye^cMCI@$E<#?LKt`VP;%QFH4aNG*JE7?V{1V=$|)bgBjje^k~w zRePIVEB}3#IOdOTrb~3;i*hVl*%RE$It7vHMTn&qJ zxijns${zwMx@fDz&Vx0z`e$_Nx|8?}rBTszz@sbYES);iH+<`Hhx3QIZtAEri{0MG ziF0(`d*U^my4O=a*!+b)txW}1e=K_2nI&5a2ypT!0iV44u@9wPw=lR397~UC9?jPP z#HWvLz)7>R{&1IF=GhY;Z8cHIp0H<|V@X9AUoL(Pj6T4>$mvF9vB>kyAR29Al-qPO zHuy&%DYf7zl7Rybl^7(gnd&PIJYHVPw}lFNtG7sNV1Qv0OJEns2ugS1`;56Jmm3lx1aXOfaqcx>npLiYi^-?NP$9 zeS5CBZ=SYAJF_ArMs*Qt!DH*>kNjU%6Fp^XS`(LaL*2UT9`Xp%wf{%TV0J)>%uVo^M5eGK-6iY}GlGjbYg z;UuOMvH|?gp1-Ud8o37gnkPn6)Kyd1kr=ied?YX0Ers8!#1g4>q!HIti`jWpRBKP)s{s(0eUy<&`4sbD%RZB%YoChAe^I z->#dQYNwGdC3!6BNVqt$a`dBjO~&i!}B{X@v<;pVBVTP1b*+^{&%r8F*Y z8rN1rh?7SnA2o7LV`IH~2{p!9@8*C(`kcimzMZaY-lrEqfoCHtbBkGS*m1N{%pZpR zxrNulOGf((XpL5&Oa0lC6eGLv5b&;O;)k)%SgdJqSW#N)bQXU(is^;dK95P|1OYQd z$y!^B1qXVixWF64s+K`ItSerR?Mn$&#nO=PCFM26xTI?SbSDlR`w_Qie?8ndIFC$M z^Pc)GWzz`l6%BFxaRUFz;;@1QWRFA!TbGA%BU(TRy&)HonyQC3y&SW|D_pA%G})nQ z)PF*^z066>+p&2c*oiI_@pTaLZobJY(g)nKmKUM-sNeaFePOaK@P}U(lNUe>uMR3h zo2b9lOD#z4T0z`Vc5JVyQdJqRR70GGhkjk99>w?qoxe`GH3SIqrXJz825j<=`WNt| zA?KAT@zo-)3Otf9`(zbDfBhwYJ0{t@QR6NSLZhYey5CfBJQ5tr+jmw7!&r|Q)pxZp zsyEm#3*_j!_jyt3ZncTLS?ua|`}xIX`fwzq=A9JLNAETyDY%knPG2b?2Pta}MgomD zSaK*PKQ_@l+{!OMSf4L&$0@5OUV91Osg3RJa;%>stWP((udFeZr7!9FeBFYi$Rm@N z?r$v!3yg=Pvw@E#-7tt_Q0-W}to!nxm+SW#atqExUGD~d^9CI~{Q-kcH=*1p7B!-r zVVZA~J^Xh}S?HESeac>V$iUew$~QE_vFHxc#0%GXJJ?c8nyT5ydwwNYe?2|*3j22x zF_Jg(Urj`kUN7`nSb56v$9whNJLCHJa0zbdHNl4Ir@+Pl2LGJtRXKi+ zWPpP3e~?-c&0jZj{(rfc|LCqdHvn%9#!apCzChHNO^&V6iE21aRVLk?&{L!1(@FPq zT6o^>WLQkX$~g`X>2_`^Ku+(Nv<ZiSxh+JSi95wK54_!+ag8RB<~K2kM%Zg&T< z*`_NfL4oX1oR?=8%X3EDyhltL;R!Km4`=ugM z{$Hl!g9N!W`wlL!CG&^ypJMf{Q{0tb#!4B`y_mG^C1uqvx{bI5ZK{Ed_V-jo<_9L~ z>@gY{-<2r5EvL1`9Lx)1CuUz78OG z3RiI3mMrMI}4F5_&Elh|`@$k=f!CO0+%B8v%`93n;c!U6wY0MaGiB z9CMX?BxFStc&^upIr7lPx@Z5W@3tI0IL+UrLkPY*3y7RX+&fuI0UQ4O?ma9^4eN?# z@RJ+lA`*)I2ER60a!H4p4q26XDn944mBypC)2h7As&G8gRl}A^aoV1o7?2>x1&mG9L}5`3Tf`HVDC=2_08;jN2(kk0#AOOETc=?ZkTA!$8i_&R!K zDW>^>%&FD>CsvJp{)iY?1&rKPyVMU&SQ%(WnbD1=7@jzlBp_s498Ra?#vf4T1-hB&v0zgEkwL=1#)Z>+)jvnKzS6B z6&cYpk@?OswJm;tukK6i-y?7Wo_U;9H%?wWPd-i4v1l(B6k#8e2B)*KBTJ^3c*Scf zX+P8TOu58e59`K}T+93RX84&Xp897X;-^l+iMDqsZ~S_e>QTW$J0=hLsglI(EtCNx z;d|8DCaA-kX))|ouABLDAD`$|#^yIhrSWdQN1P%uL_SpUe<2qaoB#uAHe4k~uri@I z9@wKRoPvbu9gShz20J(G*yJsO@qMVJ+mwFdP$W-JZn@9ff#YWp0bJe`eCKseO`S%Z zKwB%FdL~2ko6}{FNxQ{Jxpnfx(eD=$@8@-=41AD9u2V|_jpyz4QJqHNB4ts@peu@Z zU*n5mCK0FRZL=wub?Vi=fq-CfQ{ML_H^XW+Hu?E)ECCnhFK9E3WTHL&hM4Y@_7!%{ z!yogTQii|^*VcDj>twBL=?dK|@K-@zYjSWIIRGh-Id)o0-uc5LBCGB&r?a@C~VeSAnJ89)M$LdepD!}x_h{L8yjg?e!_i$*Aq|%5;8C?C*>gf<9x1W+B zTj;8Hw_dKJB75$!jzMGl&`;~&EqNoX~Rj>^GH~->JkN^Mx literal 0 HcmV?d00001 diff --git a/pull_request_template.md b/pull_request_template.md index d5cfa69..e73c403 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,6 +1,9 @@ # Pull Request Template ## 📝 Instructions +Before you add a summary to your pull request, click on the `Preview` button in GitHub to see how your selected template will appear: +![Preview button](Preview_button.png) + Please choose the appropriate template based on the nature of your changes. Use one of the following templates: - **[Code Changes Template](https://github.com/PyCeas/Pyceas/compare/main?expand=1&template=code_pr_template.md)** @@ -28,4 +31,4 @@ If you are not sure which template to choose, refer to the descriptions below: --- ## 🔗 Related Links -For more information, check the [Contributing Guidelines](/CONTRIBUTING.md) for details on submitting pull requests. \ No newline at end of file +For more information, check the [Contributing Guidelines](https://github.com/PyCeas/Pyceas/blob/main/CONTRIBUTING.md) for details on submitting pull requests. \ No newline at end of file From 23f6753bfd59fad57bcf05dc586a35771a58aebc Mon Sep 17 00:00:00 2001 From: ultimateownsz Date: Fri, 14 Feb 2025 15:54:18 +0100 Subject: [PATCH 4/5] fix important message --- pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index e73c403..8efa109 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -12,8 +12,9 @@ Please choose the appropriate template based on the nature of your changes. Use - **[Asset Changes](https://github.com/PyCeas/Pyceas/compare/main?expand=1&template=asset_pr_template.md)** - **[Audio Changes](https://github.com/PyCeas/Pyceas/compare/main?expand=1&template=audio_pr_template.md)** -> ![IMPORTANT] +> [!IMPORTANT] > When creating a pull request, make sure the base branch is set to `main`. If you are working from a different branch, you can update the target branch > in the pull request interface. +> --- From 1101b219e8e2d31684148d12393cef035eb9fb2b Mon Sep 17 00:00:00 2001 From: ultimateownsz Date: Fri, 14 Feb 2025 16:02:50 +0100 Subject: [PATCH 5/5] comment out specific repository check this will comment out the specific repository check, could be helpful is we refactor the classis cli version later on --- .github/workflows/lint_and_test.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/lint_and_test.yml b/.github/workflows/lint_and_test.yml index 49e064c..f29d561 100644 --- a/.github/workflows/lint_and_test.yml +++ b/.github/workflows/lint_and_test.yml @@ -15,12 +15,12 @@ jobs: - name: Checkout code uses: actions/checkout@v4 - - name: Exit if not Pyceaas repository - run: | - if [ "${{ github.repository }}" != "PyCeas/Pyceas" ]; then - echo "Not running in PyCeas repository. Exiting." - exit 0 - fi + # - name: Exit if not Pyceaas repository + # run: | + # if [ "${{ github.repository }}" != "PyCeas/Pyceas" ]; then + # echo "Not running in PyCeas repository. Exiting." + # exit 0 + # fi - name: Set up Python uses: actions/setup-python@v5