Inject Algosigner also into Iframes

[andpay-io]

Hi,

We're Andpay - building the first pure PSP fully on the Algorand blockchain. Lately we've integrated support with Algosigner, however we found out that Algosigner isn't compatible with our embeddable components (iframe based).

We noticed that the JS file that's being added is only injected in the top-level document frame and not on all the underlying iframes within that page. Could the Algosigner extension be updated with:

"content_scripts": [ { ... "all_frames": true, ... } ],
As explained here: https://developer.chrome.com/docs/extensions/mv3/content_scripts/#frames

This should potentially make it possible to also run Algosigner support within iframes. Hope to see this implemented soon - as currently Algosigner won't be offered as Payment option within our embeddable components.

[andpay-io]

Hi @janmarcano,

Any chance that this will be picked up in any of the upcoming releases?
Thanks!

[janmarcano]

Hello! We're currently evaluating the impact it would have on pages with lots of iframes, as that would load AlgoSigner everywhere, even on sites that have nothing to do with AlgoSigner/Algorand.

I'll be sure to let you know if/when we decide to tackle this for a future update.

[andpay-io]

Hi @janmarcano,

Thanks! Maybe another option could be to only add it to iframes that have a certain class or property. Could minimise impact, but helps re-usability for cases like ours.

[mataide]

Need that as well.

[mataide]

@andpay-io do you know if it's possible to do a workaround?

[andpay-io]

@mataide Unfortunately not, we haven't found a workaround for this issue.