Skip to content

This repository has no history, making it hard to review #1

@eternaleye

Description

@eternaleye

This repository seems to be based on P-H-C/phc-winner-argon2 - however, it seems like the code was committed to an entirely new repository, losing the history and making it difficult to review the changes in isolation.

I've taken the liberty of integrating the changes over the commit that they seem to have been developed on top of (P-H-C/phc-winner-argon2@30c78a1) in eternaleye/Argon2-Practical-Graph:preserve-history, followed by rebasing them onto current master in eternaleye/Argon2-Practical-Graph:preserve-history-rebased.

I also changed the commenting-out of the distribution calculation to use #if 0, to minimize the amount of unnecessary churn (such as stripping the /* */ comment directives from comments in that section).

I'd appreciate if you'd review what I did to make sure I haven't made any mistakes, and possibly integrate the incremental form in this repository for ease of comprehension and review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions