diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 53a13871..85f96c5d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -8,9 +8,7 @@ jobs: strategy: fail-fast: false matrix: -# disabled windows due node packages issues -# os: [ubuntu-latest, macos-latest, windows-latest] - os: [ubuntu-latest, macos-latest] + os: [ubuntu-latest, macos-latest, windows-latest] python-version: [ '2.x', '3.x', '3.5', '3.6', '3.7', '3.8', '3.9', 'pypy-2.7', 'pypy-3.6', 'pypy-3.7' ] exclude: - os: windows-latest diff --git a/js2py/node_import.py b/js2py/node_import.py index 21844314..53e54600 100644 --- a/js2py/node_import.py +++ b/js2py/node_import.py @@ -21,8 +21,8 @@ def _init(): 'node -v', shell=True, cwd=DIRNAME ) == 0, 'You must have node installed! run: brew install node' assert subprocess.call( - 'cd %s;npm install babel-core babel-cli babel-preset-es2015 babel-polyfill babelify browserify browserify-shim' - % repr(DIRNAME), + 'cd "%s" && npm install babel-core babel-cli babel-preset-es2015 babel-polyfill babelify browserify browserify-shim' + % DIRNAME, shell=True, cwd=DIRNAME) == 0, 'Could not link required node_modules' DID_INIT = True @@ -94,7 +94,7 @@ def _get_and_translate_npm_module(module_name, include_polyfill=False, update=Fa pkg_name += '@' + maybe_version_str # make sure the module is installed assert subprocess.call( - 'cd %s;npm install %s' % (repr(DIRNAME), pkg_name), + 'cd "%s" && npm install %s' % (DIRNAME, pkg_name), shell=True, cwd=DIRNAME ) == 0, 'Could not install the required module: ' + pkg_name