From 36024fea0a1e8feb017f86864c439d49bd24b267 Mon Sep 17 00:00:00 2001 From: Jules Boulet Date: Mon, 8 Dec 2025 15:09:31 +0100 Subject: [PATCH 01/49] fix(WindowEvents): delete records linked to openning --- .../DSAbstractDebugPointEventRecord.class.st | 1 - DebuggingSpy/DSAbstractEventRecord.class.st | 3 +- .../DSPlaygroundOpenedRecord.class.st | 20 ----------- DebuggingSpy/DSPlaygroundReadRecord.class.st | 26 -------------- DebuggingSpy/DSPlaygroundRecord.class.st | 21 ----------- DebuggingSpy/DSPlaygroundWriteRecord.class.st | 25 ------------- DebuggingSpy/DSSpyInstrumenter.class.st | 35 ++----------------- 7 files changed, 4 insertions(+), 127 deletions(-) delete mode 100644 DebuggingSpy/DSPlaygroundOpenedRecord.class.st delete mode 100644 DebuggingSpy/DSPlaygroundReadRecord.class.st delete mode 100644 DebuggingSpy/DSPlaygroundRecord.class.st delete mode 100644 DebuggingSpy/DSPlaygroundWriteRecord.class.st diff --git a/DebuggingSpy/DSAbstractDebugPointEventRecord.class.st b/DebuggingSpy/DSAbstractDebugPointEventRecord.class.st index 2863995..7957707 100644 --- a/DebuggingSpy/DSAbstractDebugPointEventRecord.class.st +++ b/DebuggingSpy/DSAbstractDebugPointEventRecord.class.st @@ -9,7 +9,6 @@ Class { 'target', 'behaviors', 'arguments', - 'link', 'enabled', 'eventName', 'debugPointHash' diff --git a/DebuggingSpy/DSAbstractEventRecord.class.st b/DebuggingSpy/DSAbstractEventRecord.class.st index 5e6924f..3913fc4 100644 --- a/DebuggingSpy/DSAbstractEventRecord.class.st +++ b/DebuggingSpy/DSAbstractEventRecord.class.st @@ -7,7 +7,8 @@ Class { #instVars : [ 'dateTime', 'windowId', - 'uuid' + 'uuid', + 'link' ], #category : 'DebuggingSpy-Records', #package : 'DebuggingSpy', diff --git a/DebuggingSpy/DSPlaygroundOpenedRecord.class.st b/DebuggingSpy/DSPlaygroundOpenedRecord.class.st deleted file mode 100644 index 3a42b99..0000000 --- a/DebuggingSpy/DSPlaygroundOpenedRecord.class.st +++ /dev/null @@ -1,20 +0,0 @@ -" -I record that a StPlayground opened. -" -Class { - #name : 'DSPlaygroundOpenedRecord', - #superclass : 'DSPlaygroundRecord', - #category : 'DebuggingSpy-Records', - #package : 'DebuggingSpy', - #tag : 'Records' -} - -{ #category : 'accessing' } -DSPlaygroundOpenedRecord >> eventName [ - ^'Playground open' -] - -{ #category : 'accessing - structure variables' } -DSPlaygroundOpenedRecord >> glyph [ - ^'P' -] diff --git a/DebuggingSpy/DSPlaygroundReadRecord.class.st b/DebuggingSpy/DSPlaygroundReadRecord.class.st deleted file mode 100644 index 17e2ab7..0000000 --- a/DebuggingSpy/DSPlaygroundReadRecord.class.st +++ /dev/null @@ -1,26 +0,0 @@ -" -I record that a mouse entered a StPlayground's code, which may indicate that the developer is reading the code. -" -Class { - #name : 'DSPlaygroundReadRecord', - #superclass : 'DSPlaygroundRecord', - #category : 'DebuggingSpy-Records', - #package : 'DebuggingSpy', - #tag : 'Records' -} - -{ #category : 'accessing' } -DSPlaygroundReadRecord >> context [ - ^'Reading code' -] - -{ #category : 'accessing' } -DSPlaygroundReadRecord >> eventName [ - - ^ 'Playground read' -] - -{ #category : 'accessing - structure variables' } -DSPlaygroundReadRecord >> glyph [ - ^'PR' -] diff --git a/DebuggingSpy/DSPlaygroundRecord.class.st b/DebuggingSpy/DSPlaygroundRecord.class.st deleted file mode 100644 index 0f7931f..0000000 --- a/DebuggingSpy/DSPlaygroundRecord.class.st +++ /dev/null @@ -1,21 +0,0 @@ -" -I record events that happens in a StPlayground. -I do not really serve any purpose as an abstract class, but I'm just there to provide quick access to my subclasses' instances. -" -Class { - #name : 'DSPlaygroundRecord', - #superclass : 'DSAbstractEventRecord', - #category : 'DebuggingSpy-Records', - #package : 'DebuggingSpy', - #tag : 'Records' -} - -{ #category : 'accessing - structure variables' } -DSPlaygroundRecord >> glyphColor [ - ^Color blue darker -] - -{ #category : 'actions api' } -DSPlaygroundRecord >> record: aPresenter [ - super record: aPresenter window window -] diff --git a/DebuggingSpy/DSPlaygroundWriteRecord.class.st b/DebuggingSpy/DSPlaygroundWriteRecord.class.st deleted file mode 100644 index 2ba6af7..0000000 --- a/DebuggingSpy/DSPlaygroundWriteRecord.class.st +++ /dev/null @@ -1,25 +0,0 @@ -" -I record that the developer is typing in an StPlayground. -" -Class { - #name : 'DSPlaygroundWriteRecord', - #superclass : 'DSPlaygroundRecord', - #category : 'DebuggingSpy-Records', - #package : 'DebuggingSpy', - #tag : 'Records' -} - -{ #category : 'accessing' } -DSPlaygroundWriteRecord >> context [ - ^'Writing code' -] - -{ #category : 'accessing' } -DSPlaygroundWriteRecord >> eventName [ - ^'Playground write' -] - -{ #category : 'accessing - structure variables' } -DSPlaygroundWriteRecord >> glyph [ - ^'PW' -] diff --git a/DebuggingSpy/DSSpyInstrumenter.class.st b/DebuggingSpy/DSSpyInstrumenter.class.st index c8e5a06..05c562a 100644 --- a/DebuggingSpy/DSSpyInstrumenter.class.st +++ b/DebuggingSpy/DSSpyInstrumenter.class.st @@ -113,22 +113,6 @@ DSSpyInstrumenter >> instrumentDebuggerCommands [ ] -{ #category : 'debugger' } -DSSpyInstrumenter >> instrumentDebuggerOpening [ - - StDebugger compile: 'initializeWindow: aWindowPresenter - - super initializeWindow: aWindowPresenter. - aWindowPresenter - initialPosition: self settings lastKnownPosition; - whenClosedDo: [ self clear ]. - - self settings initializeWindow: aWindowPresenter. - self initializeShortcuts: aWindowPresenter. - - [DSDebuggerOpeningRecord for: self ] on: Error do:[:err| DSSpy log: err key: #DEBUGGER_STACK ] ' -] - { #category : 'debugger' } DSSpyInstrumenter >> instrumentDebuggerStack [ @@ -316,17 +300,6 @@ DSSpyInstrumenter >> instrumentNavigateAttribute [ do: [ :err | DSSpy log: #ERROR key: #INSPECTOR_OBSERVE ] ] ]' ] -{ #category : 'playground' } -DSSpyInstrumenter >> instrumentPlaygroundCode [ - - StPlaygroundPresenter class compile: 'open -