From 635ea6a6b7e434243ffb058e1e54e1ac988a589c Mon Sep 17 00:00:00 2001 From: egnaf Date: Sat, 3 Aug 2019 16:52:36 +0300 Subject: [PATCH 1/4] Optimize imports --- src/test/java/com/patreon/PatreonAPITest.java | 6 +----- src/test/java/com/patreon/PatreonOAuthTest.java | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/test/java/com/patreon/PatreonAPITest.java b/src/test/java/com/patreon/PatreonAPITest.java index 34876f6..0b26888 100644 --- a/src/test/java/com/patreon/PatreonAPITest.java +++ b/src/test/java/com/patreon/PatreonAPITest.java @@ -9,9 +9,7 @@ import org.apache.http.NameValuePair; import org.apache.http.client.utils.URLEncodedUtils; import org.mockito.ArgumentCaptor; -import org.mockito.Matchers; import org.mockito.Mockito; -import org.powermock.api.mockito.PowerMockito; import java.nio.charset.Charset; import java.util.Arrays; @@ -20,9 +18,7 @@ import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.eq; -import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; +import static org.mockito.Mockito.*; public class PatreonAPITest extends TestCase { private static final String MOCK_TOKEN = "some token"; diff --git a/src/test/java/com/patreon/PatreonOAuthTest.java b/src/test/java/com/patreon/PatreonOAuthTest.java index 5552461..11d33d2 100644 --- a/src/test/java/com/patreon/PatreonOAuthTest.java +++ b/src/test/java/com/patreon/PatreonOAuthTest.java @@ -1,7 +1,6 @@ package com.patreon; import junit.framework.TestCase; -import org.apache.commons.io.Charsets; import org.apache.commons.io.IOUtils; import org.jsoup.Connection; import org.jsoup.Jsoup; @@ -10,8 +9,6 @@ import org.jsoup.nodes.Element; import org.junit.runner.RunWith; import org.mockito.Mockito; -import org.mockito.invocation.InvocationOnMock; -import org.mockito.stubbing.Answer; import org.powermock.api.mockito.PowerMockito; import org.powermock.core.classloader.annotations.PrepareForTest; import org.powermock.modules.junit4.PowerMockRunner; From 4fd4ca6e0864b9d55eacafffcdc9df62a870c93a Mon Sep 17 00:00:00 2001 From: egnaf Date: Sat, 3 Aug 2019 16:53:24 +0300 Subject: [PATCH 2/4] Fix assertion to simplify --- src/test/java/com/patreon/PatreonAPITest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/patreon/PatreonAPITest.java b/src/test/java/com/patreon/PatreonAPITest.java index 0b26888..94b402a 100644 --- a/src/test/java/com/patreon/PatreonAPITest.java +++ b/src/test/java/com/patreon/PatreonAPITest.java @@ -40,7 +40,7 @@ public void testFetchCampaigns() throws Exception { Campaign campaign = campaignResponse.get().get(0); assertEquals("70261", campaign.getId()); assertEquals("/bePatron?c=70261", campaign.getPledgeUrl()); - assertEquals(false, campaign.isChargedImmediately()); + assertFalse(campaign.isChargedImmediately()); assertEquals("212633030584565760", campaign.getDiscordServerId()); assertEquals("32187", campaign.getCreator().getId()); assertEquals(3, campaign.getGoals().size()); From be1f06987b115be04172a5ad668a963604e51d83 Mon Sep 17 00:00:00 2001 From: egnaf Date: Sat, 3 Aug 2019 16:57:42 +0300 Subject: [PATCH 3/4] Fix property access modifier to private --- src/test/java/com/patreon/PatreonOAuthTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/patreon/PatreonOAuthTest.java b/src/test/java/com/patreon/PatreonOAuthTest.java index 11d33d2..21f2caf 100644 --- a/src/test/java/com/patreon/PatreonOAuthTest.java +++ b/src/test/java/com/patreon/PatreonOAuthTest.java @@ -18,7 +18,7 @@ @RunWith(PowerMockRunner.class) @PrepareForTest({Jsoup.class, Document.class, HttpConnection.class, Connection.Response.class}) public class PatreonOAuthTest extends TestCase { - PatreonOAuth oauth = new PatreonOAuth( + private PatreonOAuth oauth = new PatreonOAuth( "a client id", "your secret", "your redirect URI" From a1984564f69cb4a3c2a663785ae9dcc5f86b2b3b Mon Sep 17 00:00:00 2001 From: egnaf Date: Sat, 3 Aug 2019 16:59:42 +0300 Subject: [PATCH 4/4] Remove "Exception" from "testAuthorizationURL" throws list --- src/test/java/com/patreon/PatreonOAuthTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/patreon/PatreonOAuthTest.java b/src/test/java/com/patreon/PatreonOAuthTest.java index 21f2caf..7c40f6e 100644 --- a/src/test/java/com/patreon/PatreonOAuthTest.java +++ b/src/test/java/com/patreon/PatreonOAuthTest.java @@ -24,7 +24,7 @@ public class PatreonOAuthTest extends TestCase { "your redirect URI" ); - public void testAuthorizationURL() throws Exception { + public void testAuthorizationURL() { String url = oauth.getAuthorizationURL(); assertEquals("https://www.patreon.com/oauth2/authorize?response_type=code&client_id=a+client+id&redirect_uri=your+redirect+URI", url); }