Skip to content

Unreachable notification step in iOS SDK CI #46

@pi-alexander-popel

Description

@pi-alexander-popel

The Build failure Post to Slack step checks for the previous step's failure instead of the build failure. This is likely not indentional, and also means that the step will never run since the previous step only runs on tag pushes, and the step in question only runs on PRs.

- name: Build failure Post to Slack
uses: slackapi/slack-github-action@v2.0.0
if: ${{ failure() && github.event_name == 'pull_request' }}

The full fix would have to add the if: always() conditional to the job iself, and then check needs.<job_id>.result in the job steps.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions