Use std::string_view at least in input arguments in place of char*

[lhamot]

[moldyharriet]

Mind if I work on this?

Also, I'm new to the open source dev world..What's the best way for me to find which files I need to make this change on?

Thanks!

[lhamot]

Hello Chase ! @moldyharriet
You could start to build EntityLib, build schemas and run unit tests.
The build process can be a little bit rude so do not hesitate to ask me.

Maybe you can start by the class FileProperty, in FileProperty.h and .cpp.
The idea is to replace char const* by std::string_view in function parameter, but not in return value.
For example :

// This one 
[[nodiscard]] bool erasePrimSetKey(char const* _key);
// will be replaced by :
[[nodiscard]] bool erasePrimSetKey(std::string_view _key);
// But this one will not be changed :
[[nodiscard]] char const* getFilePath() const;

Do you know the difference between char const* and std::string_view and the advantages and disadvantages of each ?

Try to change just one method to start and run the unit test. If it is ok, you can change more.

When you are satisfied, please make a branch names let's say feature/string_view_in_fileproperty, and then make a PR and set me as a reviewer.