From c2768304a623892e37138a1e458fbc8e067f4c10 Mon Sep 17 00:00:00 2001 From: EvansAF <70555148+EvansAF@users.noreply.github.com> Date: Sat, 18 Nov 2023 19:51:07 +0000 Subject: [PATCH] Update BanksController.java My suggestion is that it is better to inject ObpBankMetaApiClient obpBankMetaApiClient through the constructor in modern practice for various reasons --- src/main/java/com/tesobe/obp/api/BanksController.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/tesobe/obp/api/BanksController.java b/src/main/java/com/tesobe/obp/api/BanksController.java index 59c2dfb..19b8aca 100644 --- a/src/main/java/com/tesobe/obp/api/BanksController.java +++ b/src/main/java/com/tesobe/obp/api/BanksController.java @@ -18,8 +18,11 @@ @Slf4j public class BanksController { - @Autowired - private ObpBankMetaApiClient obpBankMetaApiClient; + private final ObpBankMetaApiClient obpBankMetaApiClient; + + public BanksController(ObpBankMetaApiClient obpBankMetaApiClient) { + this.obpBankMetaApiClient = obpBankMetaApiClient; + } @GetMapping("/branches") public List allBranches() {