[16.0] fs_storage: issues with the rooted_dir_file_system

[hnavarro-kernet]

We are experiencing this intermittent issue where any uploads or reads from a configured fs.storage with s3fs are raising FileNotFoundError anytime os.getcwd() is called.

Module

fs_storage

Describe the bug

Mostly, anytime you try to see an image, upload an attachment, etc. if Odoo has to "contact" the external S3 bucket, it will raise FileNotFoundError from os.getcwd().

To Reproduce

Affected versions:
16.0
Possible anything else with the rooted_dir_file_system

Steps to reproduce the behavior:

1. If you have the bug, just refresh the record. For example in a project.task I sent some images to my customer, if I refresh the task, the images won't load or load sometimes and other times not.

Expected behavior
Issue not raising.

Additional context

Traceback (most recent call last):
  File "/opt/odoo/OCB/odoo/http.py", line 2234, in __call__
    response = request._serve_db()
  File "/opt/odoo/OCB/odoo/http.py", line 1822, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/OCB/odoo/service/model.py", line 152, in retrying
    result = func()
  File "/opt/odoo/OCB/odoo/http.py", line 1850, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/OCB/odoo/http.py", line 1964, in dispatch
    return self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/OCB/addons/website/models/ir_http.py", line 237, in _dispatch
    response = super()._dispatch(endpoint)
  File "/opt/odoo/OCB/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/OCB/odoo/http.py", line 761, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/OCB/addons/web/controllers/binary.py", line 171, in content_image
    return stream.get_response(**send_file_kwargs)
  File "/opt/odoo/kernet/oca/fs_attachment/fs_stream.py", line 72, in get_response
    res = _send_file(f, **send_file_kwargs)
  File "/opt/odoo/OCB/odoo/tools/_vendor/send_file.py", line 104, in send_file
    if isinstance(path_or_file, (os.PathLike, str)) or hasattr(
  File "/opt/odoo/kernet/oca/fs_attachment/models/ir_attachment.py", line 1142, in __getattr__
    self.__enter__()
  File "/opt/odoo/kernet/oca/fs_attachment/models/ir_attachment.py", line 989, in __enter__
    self._file_open()
  File "/opt/odoo/kernet/oca/fs_attachment/models/ir_attachment.py", line 1009, in _file_open
    fs, _storage, fname = self.attachment._get_fs_parts()
  File "/opt/odoo/kernet/oca/fs_attachment/models/ir_attachment.py", line 594, in _get_fs_parts
    return self._fs_parse_store_fname(self.store_fname)
  File "/opt/odoo/kernet/oca/fs_attachment/models/ir_attachment.py", line 527, in _fs_parse_store_fname
    fs = self._get_fs_storage_for_code(storage_code)
  File "/opt/odoo/kernet/oca/fs_attachment/models/ir_attachment.py", line 511, in _get_fs_storage_for_code
    fs = self.env["fs.storage"].get_fs_by_code(code)
  File "<decorator-gen-142>", line 2, in get_fs_by_code
  File "/opt/odoo/OCB/odoo/tools/cache.py", line 90, in lookup
    value = d[key] = self.method(*args, **kwargs)
  File "/opt/odoo/kernet/oca/fs_storage/models/fs_storage.py", line 227, in get_fs_by_code
    fs = fs_storage.fs
  File "/opt/odoo/kernet/oca/fs_storage/models/fs_storage.py", line 323, in fs
    raise e
  File "/opt/odoo/kernet/oca/fs_storage/models/fs_storage.py", line 319, in fs
    self._check_connection(self.__fs, self.check_connection_method)
  File "/opt/odoo/kernet/oca/fs_storage/models/fs_storage.py", line 306, in _check_connection
    self._ls_check_connection(fs)
  File "/opt/odoo/kernet/oca/fs_storage/models/fs_storage.py", line 300, in _ls_check_connection
    fs.ls("", detail=False)
  File "/opt/odoo/odooenv/lib/python3.8/site-packages/fsspec/implementations/dirfs.py", line 254, in ls
    ret = self.fs.ls(self._join(path), detail=detail, **kwargs).copy()
  File "/opt/odoo/kernet/oca/fs_storage/rooted_dir_file_system.py", line 47, in _join
    path_posix = os.path.normpath(make_path_posix(path))
  File "/opt/odoo/odooenv/lib/python3.8/site-packages/fsspec/implementations/local.py", line 304, in make_path_posix
    return f"{os.getcwd()}/{path}"
FileNotFoundError: [Errno 2] No such file or directory

A successful read looks like this:

2025-09-16 09:30:15,024 660916 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: ********************************************************************************
2025-09-16 09:30:15,024 660916 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: rooted_dir path: <bucket-name>/<file-checksum>
2025-09-16 09:30:15,024 660916 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: rooted_dir self.path: <bucket-name>
2025-09-16 09:30:15,025 660916 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: rooted_dir os.getcwd(): /opt/odoo
2025-09-16 09:30:15,025 660916 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: ********************************************************************************

A failed read looks like this:

2025-09-16 09:30:14,956 660907 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: ********************************************************************************
2025-09-16 09:30:14,956 660907 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: rooted_dir path: <bucket-name>
2025-09-16 09:30:14,956 660907 INFO odoo odoo.addons.fs_storage.rooted_dir_file_system: rooted_dir self.path: <bucket-name>
2025-09-16 09:30:14,956 660907 ERROR odoo odoo.addons.fs_storage.rooted_dir_file_system: [Errno 2] No such file or directory

In our /etc/systemd/system/odoo.service we have specified the WorkingDirectory:
WorkingDirectory=/opt/odoo

Any clue or fixes for this?

[hnavarro-kernet]

Additional note, this issue has raised both with the file marker method to check the connection and with the current list file method.

[hnavarro-kernet]

I had a feeling that if I restarted the server, this would get fixed... and it did indeed. Which makes me think it's something related to the workers? How Odoo spawns/manages workers? Maybe the server suffered a restart?

Current configuration file:

[options]
admin_passwd = XXXXXXXXXX
db_host = XXXXXXXXXX
db_port = XXXXXXXXXX
db_user = XXXXXXXXXX
db_password = XXXXXXXXXX

server_wide_modules =
    base,
    web,
    sentry,
    queue_job

addons_path =
    /opt/odoo/kernet/extra-addons,
    /opt/odoo/kernet/kernet,
    /opt/odoo/kernet/oca,
    /opt/odoo/design-themes,
    /opt/odoo/OCB/addons
    

data_dir = /var/lib/odoo
proxy_mode = True
unaccent = True

; Settings XMLRPC & Multiprocessing
limit_time_cpu = 600
limit_time_real = 1200

max_cron_threads = 3
workers = 9

;Log Settings
logfile = /var/log/odoo/odoo-server.log
log_level = debug

; Sentry Configuration
sentry_dsn = XXXXXXXXXX
sentry_traces_sample_rate = 1.0
sentry_profiles_sample_rate = 1.0
sentry_enabled = true
sentry_environment = production
sentry_logging_level = error
sentry_exclude_loggers =
    werkzeug,
    odoo.addons.google_account.models.google_service


[queue_job]
channels = root:2

[hnavarro-kernet]

I have a possible fix...

Reading the authors' initial intention:

The main purpose of this filesystem is to ensure that paths are always a sub path of the initial path.

I thought we could do this virtually instead of relying on make_posix_path which uses I/O operations with the mentioned os.getcwd() calls that provoke the error.

So I rewrote the _join function, registered the implementation using clobber=True to overwrite and so far it's looking great. Tomorrow during work hours I'll be able to see if it's robust enough, but I think so.

Here's the new function.
EDIT: The snippet is no longer valid, causing issues that were caught by the test suite. Please refer to the PR #522.

[hnavarro-kernet]

10 days later, no issues were reported back with this implementation.

If someone wants to open a PR before I do is welcome to do so.

Feel free to take the snippet above or the full override for a custom module below.
EDIT: The snippet is no longer valid, causing issues that were caught by the test suite. Please refer to the PR #522.

[ivs-cetmix]

Hi @hnavarro-kernet , thank you for reporting this! Would appreciate you opening a PR with the fix so it could be reviewed.